* [pve-devel] [PATCH manager] ui: fix 'no iommu found' message for setups
@ 2020-11-20 14:29 Dominik Csapak
2020-11-20 14:36 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2020-11-20 14:29 UTC (permalink / raw)
To: pve-devel
sometimes, the first device in the pci api call is not in a separate
iommu group (see e.g. [0]), but it is active and should work
instead of testing the first, test all, and only show the message
if no device has a set iommu group
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/qemu/PCIEdit.js | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/www/manager6/qemu/PCIEdit.js b/www/manager6/qemu/PCIEdit.js
index b10326ba..72a355d0 100644
--- a/www/manager6/qemu/PCIEdit.js
+++ b/www/manager6/qemu/PCIEdit.js
@@ -93,8 +93,7 @@ Ext.define('PVE.qemu.PCIInputPanel', {
return;
}
- var first = records[0];
- if (first.data.iommugroup === -1) {
+ if (records.every((val) => val.data.iommugroup === -1)) {
// no iommu groups
var warning = Ext.create('Ext.form.field.Display', {
columnWidth: 1,
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH manager] ui: fix 'no iommu found' message for setups
2020-11-20 14:29 [pve-devel] [PATCH manager] ui: fix 'no iommu found' message for setups Dominik Csapak
@ 2020-11-20 14:36 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2020-11-20 14:36 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominik Csapak
On 20.11.20 15:29, Dominik Csapak wrote:
> sometimes, the first device in the pci api call is not in a separate
> iommu group (see e.g. [0]), but it is active and should work
>
> instead of testing the first, test all, and only show the message
> if no device has a set iommu group
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/manager6/qemu/PCIEdit.js | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-20 14:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-20 14:29 [pve-devel] [PATCH manager] ui: fix 'no iommu found' message for setups Dominik Csapak
2020-11-20 14:36 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal