Re: [pve-devel] [PATCH v4 serries 0/4] disk reassign: add new feature

["Dominic Jäger" <d.jaeger@proxmox.com>]

Gave it a quick test: Moving some disks from one VM to another on a CIFS
storage worked for me.  Had to do some conflict resolution upon application
though.
=> If (there is more feedback and) you rebase it, then I can test it (+ GUI) more thoroughly :)

I would probably rename the parameter name drive_key for qm to something that
already exists in our code, because to me it looks like we have different names
for it already
 - Bus/Device in the GUI
 - the word (ide, scsi)  is called Bus/Controller in man qm
 - the word is called interface (of a drive) in QemuServer.pm
 - we have $deviceid =~ m/^(virtio)(\d+)$/ in qemu-server, so the whole word+integer
 - and also "my $drive_id = "$drive->{interface}$drive->{index}";
 - we have "{drive_name} may be used to specify ide0, scsi1, etc ..." in the (old) Importdisk.pm
 - and in ControllerSelector.js the first half is controller and the integer is deviceid

And for me it would make sense to minimize those differences.

Tested-by: Dominic Jäger <d.jaeger@proxmox.com>

On Fri, Oct 30, 2020 at 11:42:23AM +0100, Aaron Lauterer wrote:
> Does anyone have time to take a look at the latest iteration of these patches?
> 
> Thx :)
> 
> On 10/2/20 10:23 AM, Aaron Lauterer wrote:
> > deleted as well because it still had the VMID of VM A in it's name.
> > 
> > To issue a reassign from the CLI run:
> > 
> > qm reassign_disk <source VMID> <target VMID> <drive key>
> > 
> > where <drive key> is the config key of the disk, e.g. ide0, scsi1 and so
> > on.
> > 
> > The following storage types are implemented at the moment:
> > * dir based ones
> >      * CIFS