From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH storage 1/3] don't pass along keep-options equal to zero to PBS
Date: Fri, 13 Nov 2020 14:08:53 +0100 [thread overview]
Message-ID: <20201113130855.18161-1-f.ebner@proxmox.com> (raw)
In PBS, zero is not allowed for these options.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
PVE/Storage/PBSPlugin.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/Storage/PBSPlugin.pm b/PVE/Storage/PBSPlugin.pm
index f3bf016..7b0c030 100644
--- a/PVE/Storage/PBSPlugin.pm
+++ b/PVE/Storage/PBSPlugin.pm
@@ -314,6 +314,7 @@ sub prune_backups {
my @param;
foreach my $opt (keys %{$keep}) {
+ next if $keep->{$opt} == 0;
push @param, "--$opt";
push @param, "$keep->{$opt}";
}
--
2.20.1
next reply other threads:[~2020-11-13 13:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 13:08 Fabian Ebner [this message]
2020-11-13 13:08 ` [pve-devel] [PATCH storage 2/3] prune mark: keep all if all prune options are zero/missing Fabian Ebner
2020-11-13 13:08 ` [pve-devel] [PATCH storage 3/3] prune: allow having all prune options zero/missing Fabian Ebner
2020-11-16 9:20 ` [pve-devel] applied-series: [PATCH storage 1/3] don't pass along keep-options equal to zero to PBS Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113130855.18161-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.