From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 1/1] ui: add ability to show and edit comments for backups
Date: Fri, 13 Nov 2020 10:38:52 +0100 [thread overview]
Message-ID: <20201113093852.28788-6-d.csapak@proxmox.com> (raw)
In-Reply-To: <20201113093852.28788-1-d.csapak@proxmox.com>
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/grid/BackupView.js | 43 ++++++++++++++++++++++++++++++++-
1 file changed, 42 insertions(+), 1 deletion(-)
diff --git a/www/manager6/grid/BackupView.js b/www/manager6/grid/BackupView.js
index ec0b60b2..3f06889f 100644
--- a/www/manager6/grid/BackupView.js
+++ b/www/manager6/grid/BackupView.js
@@ -227,7 +227,48 @@ Ext.define('PVE.grid.BackupView', {
selModel: sm,
tbar: {
overflowHandler: 'scroller',
- items: [ backup_btn, restore_btn, delete_btn,config_btn, '->', storagesel, '-', vmidfilterCB, storagefilter ],
+ items: [
+ backup_btn,
+ restore_btn,
+ delete_btn,
+ config_btn,
+ {
+ xtype: 'proxmoxButton',
+ text: gettext('Edit Comment'),
+ disabled: true,
+ handler: function() {
+ let volid = sm.getSelection()[0].data.volid;
+ var storage = storagesel.getValue();
+ Ext.create('Proxmox.window.Edit', {
+ autoLoad: true,
+ width: 600,
+ height: 400,
+ resizable: true,
+ title: gettext('Comment'),
+ url: `/api2/extjs/nodes/${nodename}/storage/${storage}/content/${volid}`,
+ layout: 'fit',
+ items: [
+ {
+ xtype: 'textarea',
+ layout: 'fit',
+ name: 'comment',
+ height: '100%',
+ },
+ ],
+ listeners: {
+ destroy: function() {
+ reload();
+ },
+ },
+ }).show();
+ },
+ },
+ '->',
+ storagesel,
+ '-',
+ vmidfilterCB,
+ storagefilter
+ ],
},
columns: [
{
--
2.20.1
WARNING: multiple messages have this Message-ID
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH manager 1/1] ui: add ability to show and edit comments for backups
Date: Fri, 13 Nov 2020 10:38:52 +0100 [thread overview]
Message-ID: <20201113093852.28788-6-d.csapak@proxmox.com> (raw)
In-Reply-To: <20201113093852.28788-1-d.csapak@proxmox.com>
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/grid/BackupView.js | 43 ++++++++++++++++++++++++++++++++-
1 file changed, 42 insertions(+), 1 deletion(-)
diff --git a/www/manager6/grid/BackupView.js b/www/manager6/grid/BackupView.js
index ec0b60b2..3f06889f 100644
--- a/www/manager6/grid/BackupView.js
+++ b/www/manager6/grid/BackupView.js
@@ -227,7 +227,48 @@ Ext.define('PVE.grid.BackupView', {
selModel: sm,
tbar: {
overflowHandler: 'scroller',
- items: [ backup_btn, restore_btn, delete_btn,config_btn, '->', storagesel, '-', vmidfilterCB, storagefilter ],
+ items: [
+ backup_btn,
+ restore_btn,
+ delete_btn,
+ config_btn,
+ {
+ xtype: 'proxmoxButton',
+ text: gettext('Edit Comment'),
+ disabled: true,
+ handler: function() {
+ let volid = sm.getSelection()[0].data.volid;
+ var storage = storagesel.getValue();
+ Ext.create('Proxmox.window.Edit', {
+ autoLoad: true,
+ width: 600,
+ height: 400,
+ resizable: true,
+ title: gettext('Comment'),
+ url: `/api2/extjs/nodes/${nodename}/storage/${storage}/content/${volid}`,
+ layout: 'fit',
+ items: [
+ {
+ xtype: 'textarea',
+ layout: 'fit',
+ name: 'comment',
+ height: '100%',
+ },
+ ],
+ listeners: {
+ destroy: function() {
+ reload();
+ },
+ },
+ }).show();
+ },
+ },
+ '->',
+ storagesel,
+ '-',
+ vmidfilterCB,
+ storagefilter
+ ],
},
columns: [
{
--
2.20.1
next prev parent reply other threads:[~2020-11-13 9:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 9:38 [pve-devel] [PATCH proxmox-backup/pve-storage/manager] show/edit backup comments Dominik Csapak
2020-11-13 9:38 ` [pbs-devel] " Dominik Csapak
2020-11-13 9:38 ` [pve-devel] [PATCH proxmox-backup 1/2] client/http_client: add put method Dominik Csapak
2020-11-13 9:38 ` [pbs-devel] " Dominik Csapak
2020-11-16 16:01 ` [pve-devel] applied: " Thomas Lamprecht
2020-11-16 16:01 ` [pbs-devel] applied: " Thomas Lamprecht
2020-11-13 9:38 ` [pve-devel] [PATCH proxmox-backup 2/2] client: add 'snapshot notes show/update' command Dominik Csapak
2020-11-13 9:38 ` [pbs-devel] " Dominik Csapak
2020-11-16 9:37 ` [pve-devel] " Thomas Lamprecht
2020-11-16 9:37 ` [pbs-devel] " Thomas Lamprecht
2020-11-16 9:42 ` Dominik Csapak
2020-11-16 9:42 ` [pbs-devel] " Dominik Csapak
2020-11-16 10:14 ` Thomas Lamprecht
2020-11-16 10:14 ` [pbs-devel] " Thomas Lamprecht
2020-11-13 9:38 ` [pve-devel] [PATCH storage 1/2] api2/storage/content: change to volume_size_info and add return properties Dominik Csapak
2020-11-13 9:38 ` [pbs-devel] " Dominik Csapak
2020-11-13 9:38 ` [pve-devel] [PATCH storage 2/2] Storage/Plugin: add get/update_volume_comment and implement for dir/pbs Dominik Csapak
2020-11-13 9:38 ` [pbs-devel] " Dominik Csapak
2020-11-13 9:38 ` Dominik Csapak [this message]
2020-11-13 9:38 ` [pbs-devel] [PATCH manager 1/1] ui: add ability to show and edit comments for backups Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113093852.28788-6-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.