all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox-backup/pve-storage/manager] show/edit backup comments
Date: Fri, 13 Nov 2020 10:38:47 +0100	[thread overview]
Message-ID: <20201113093852.28788-1-d.csapak@proxmox.com> (raw)

implement editing/showing comments (or notes) from pve side
for directory and pbs storages

i am not completely happy with the notes != comments mismatch
but we are not even consistent within a product (e.g. description vs comment),
so i am open to suggestions...

pve-manager depends on new pve-storage, which depends on new proxmox-backup-client

proxmox-backup:

Dominik Csapak (2):
  client/http_client: add put method
  client: add 'snapshot notes show/update' command

 src/bin/proxmox-backup-client.rs          |   1 +
 src/bin/proxmox_backup_client/mod.rs      |   2 +
 src/bin/proxmox_backup_client/snapshot.rs | 126 ++++++++++++++++++++++
 src/client/http_client.rs                 |   9 ++
 4 files changed, 138 insertions(+)
 create mode 100644 src/bin/proxmox_backup_client/snapshot.rs

pve-storage:

Dominik Csapak (2):
  api2/storage/content: change to volume_size_info and add return
    properties
  Storage/Plugin: add get/update_volume_comment and implement for
    dir/pbs

 PVE/API2/Storage/Content.pm | 92 +++++++++++++++++++++++++++++++++++--
 PVE/Storage.pm              | 24 +++++++++-
 PVE/Storage/DirPlugin.pm    | 30 ++++++++++++
 PVE/Storage/PBSPlugin.pm    | 20 ++++++++
 PVE/Storage/Plugin.pm       | 12 +++++
 5 files changed, 171 insertions(+), 7 deletions(-)

pve-manager;

Dominik Csapak (1):
  ui: add ability to show and edit comments for backups

 www/manager6/grid/BackupView.js | 43 ++++++++++++++++++++++++++++++++-
 1 file changed, 42 insertions(+), 1 deletion(-)

-- 
2.20.1





WARNING: multiple messages have this Message-ID
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup/pve-storage/manager] show/edit backup comments
Date: Fri, 13 Nov 2020 10:38:47 +0100	[thread overview]
Message-ID: <20201113093852.28788-1-d.csapak@proxmox.com> (raw)

implement editing/showing comments (or notes) from pve side
for directory and pbs storages

i am not completely happy with the notes != comments mismatch
but we are not even consistent within a product (e.g. description vs comment),
so i am open to suggestions...

pve-manager depends on new pve-storage, which depends on new proxmox-backup-client

proxmox-backup:

Dominik Csapak (2):
  client/http_client: add put method
  client: add 'snapshot notes show/update' command

 src/bin/proxmox-backup-client.rs          |   1 +
 src/bin/proxmox_backup_client/mod.rs      |   2 +
 src/bin/proxmox_backup_client/snapshot.rs | 126 ++++++++++++++++++++++
 src/client/http_client.rs                 |   9 ++
 4 files changed, 138 insertions(+)
 create mode 100644 src/bin/proxmox_backup_client/snapshot.rs

pve-storage:

Dominik Csapak (2):
  api2/storage/content: change to volume_size_info and add return
    properties
  Storage/Plugin: add get/update_volume_comment and implement for
    dir/pbs

 PVE/API2/Storage/Content.pm | 92 +++++++++++++++++++++++++++++++++++--
 PVE/Storage.pm              | 24 +++++++++-
 PVE/Storage/DirPlugin.pm    | 30 ++++++++++++
 PVE/Storage/PBSPlugin.pm    | 20 ++++++++
 PVE/Storage/Plugin.pm       | 12 +++++
 5 files changed, 171 insertions(+), 7 deletions(-)

pve-manager;

Dominik Csapak (1):
  ui: add ability to show and edit comments for backups

 www/manager6/grid/BackupView.js | 43 ++++++++++++++++++++++++++++++++-
 1 file changed, 42 insertions(+), 1 deletion(-)

-- 
2.20.1





             reply	other threads:[~2020-11-13  9:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-13  9:38 Dominik Csapak [this message]
2020-11-13  9:38 ` [pbs-devel] " Dominik Csapak
2020-11-13  9:38 ` [pve-devel] [PATCH proxmox-backup 1/2] client/http_client: add put method Dominik Csapak
2020-11-13  9:38   ` [pbs-devel] " Dominik Csapak
2020-11-16 16:01   ` [pve-devel] applied: " Thomas Lamprecht
2020-11-16 16:01     ` [pbs-devel] applied: " Thomas Lamprecht
2020-11-13  9:38 ` [pve-devel] [PATCH proxmox-backup 2/2] client: add 'snapshot notes show/update' command Dominik Csapak
2020-11-13  9:38   ` [pbs-devel] " Dominik Csapak
2020-11-16  9:37   ` [pve-devel] " Thomas Lamprecht
2020-11-16  9:37     ` [pbs-devel] " Thomas Lamprecht
2020-11-16  9:42     ` Dominik Csapak
2020-11-16  9:42       ` [pbs-devel] " Dominik Csapak
2020-11-16 10:14       ` Thomas Lamprecht
2020-11-16 10:14         ` [pbs-devel] " Thomas Lamprecht
2020-11-13  9:38 ` [pve-devel] [PATCH storage 1/2] api2/storage/content: change to volume_size_info and add return properties Dominik Csapak
2020-11-13  9:38   ` [pbs-devel] " Dominik Csapak
2020-11-13  9:38 ` [pve-devel] [PATCH storage 2/2] Storage/Plugin: add get/update_volume_comment and implement for dir/pbs Dominik Csapak
2020-11-13  9:38   ` [pbs-devel] " Dominik Csapak
2020-11-13  9:38 ` [pve-devel] [PATCH manager 1/1] ui: add ability to show and edit comments for backups Dominik Csapak
2020-11-13  9:38   ` [pbs-devel] " Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201113093852.28788-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal