* [pbs-devel] [PATCH xtermjs] fix console window title for rust template
@ 2020-11-11 10:08 Aaron Lauterer
2020-11-11 11:22 ` Thomas Lamprecht
2020-11-11 15:18 ` [pbs-devel] applied: " Thomas Lamprecht
0 siblings, 2 replies; 4+ messages in thread
From: Aaron Lauterer @ 2020-11-11 10:08 UTC (permalink / raw)
To: pbs-devel
The nodename was missing from the title because the variable name is
capitalized.
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
src/www/index.html.hbs.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/www/index.html.hbs.in b/src/www/index.html.hbs.in
index ecbea1b..0dba066 100644
--- a/src/www/index.html.hbs.in
+++ b/src/www/index.html.hbs.in
@@ -1,7 +1,7 @@
<!doctype html>
<html>
<head>
- <title>{{ nodename }} - Proxmox Console</title>
+ <title>{{ NodeName }} - Proxmox Console</title>
<link rel="stylesheet" href="/xtermjs/xterm.css?version=@VERSION@" />
<link rel="stylesheet" href="/xtermjs/style.css?version=@VERSION@" />
<script src="/xtermjs/xterm.js?version=@VERSION@" ></script>
--
2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [pbs-devel] [PATCH xtermjs] fix console window title for rust template
2020-11-11 10:08 [pbs-devel] [PATCH xtermjs] fix console window title for rust template Aaron Lauterer
@ 2020-11-11 11:22 ` Thomas Lamprecht
2020-11-11 12:07 ` Dominik Csapak
2020-11-11 15:18 ` [pbs-devel] applied: " Thomas Lamprecht
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Lamprecht @ 2020-11-11 11:22 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Aaron Lauterer
On 11.11.20 11:08, Aaron Lauterer wrote:
> The nodename was missing from the title because the variable name is
> capitalized.
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> src/www/index.html.hbs.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/www/index.html.hbs.in b/src/www/index.html.hbs.in
> index ecbea1b..0dba066 100644
> --- a/src/www/index.html.hbs.in
> +++ b/src/www/index.html.hbs.in
> @@ -1,7 +1,7 @@
> <!doctype html>
> <html>
> <head>
> - <title>{{ nodename }} - Proxmox Console</title>
> + <title>{{ NodeName }} - Proxmox Console</title>
> <link rel="stylesheet" href="/xtermjs/xterm.css?version=@VERSION@" />
> <link rel="stylesheet" href="/xtermjs/style.css?version=@VERSION@" />
> <script src="/xtermjs/xterm.js?version=@VERSION@" ></script>
>
this does not apply here?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [pbs-devel] [PATCH xtermjs] fix console window title for rust template
2020-11-11 11:22 ` Thomas Lamprecht
@ 2020-11-11 12:07 ` Dominik Csapak
0 siblings, 0 replies; 4+ messages in thread
From: Dominik Csapak @ 2020-11-11 12:07 UTC (permalink / raw)
To: pbs-devel
On 11/11/20 12:22 PM, Thomas Lamprecht wrote:
> On 11.11.20 11:08, Aaron Lauterer wrote:
>> The nodename was missing from the title because the variable name is
>> capitalized.
>>
>> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
>> ---
>> src/www/index.html.hbs.in | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/www/index.html.hbs.in b/src/www/index.html.hbs.in
>> index ecbea1b..0dba066 100644
>> --- a/src/www/index.html.hbs.in
>> +++ b/src/www/index.html.hbs.in
>> @@ -1,7 +1,7 @@
>> <!doctype html>
>> <html>
>> <head>
>> - <title>{{ nodename }} - Proxmox Console</title>
>> + <title>{{ NodeName }} - Proxmox Console</title>
>> <link rel="stylesheet" href="/xtermjs/xterm.css?version=@VERSION@" />
>> <link rel="stylesheet" href="/xtermjs/style.css?version=@VERSION@" />
>> <script src="/xtermjs/xterm.js?version=@VERSION@" ></script>
>>
>
> this does not apply here?
>
>
just fyi, it does here...
master is on
commit b0b1ab07886b801c1f40861e73579fa0f93ca3a0 (origin/master)
Author: Thomas Lamprecht <t.lamprecht@proxmox.com>
Date: Fri Aug 28 13:51:48 2020 +0200
bump version to 4.7.0-2
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pbs-devel] applied: [PATCH xtermjs] fix console window title for rust template
2020-11-11 10:08 [pbs-devel] [PATCH xtermjs] fix console window title for rust template Aaron Lauterer
2020-11-11 11:22 ` Thomas Lamprecht
@ 2020-11-11 15:18 ` Thomas Lamprecht
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2020-11-11 15:18 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Aaron Lauterer
On 11.11.20 11:08, Aaron Lauterer wrote:
> The nodename was missing from the title because the variable name is
> capitalized.
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> src/www/index.html.hbs.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-11 15:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-11 10:08 [pbs-devel] [PATCH xtermjs] fix console window title for rust template Aaron Lauterer
2020-11-11 11:22 ` Thomas Lamprecht
2020-11-11 12:07 ` Dominik Csapak
2020-11-11 15:18 ` [pbs-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal