[pbs-devel] [PATCH proxmox-backup] ui: show (local)datastore column only in global sync/verifyview

[pbs-devel] [PATCH proxmox-backup] ui: show (local)datastore column only in global sync/verifyview

[Dominik Csapak]

its rather hacky, but our cbind mixin does not support columns (yet).
if it does sometime in the future, we could use that instead

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/config/SyncView.js   |  9 +++++++++
 www/config/VerifyView.js | 14 ++++++++++++++
 2 files changed, 23 insertions(+)

diff --git a/www/config/SyncView.js b/www/config/SyncView.js
index 24990ff0..cac812de 100644
--- a/www/config/SyncView.js
+++ b/www/config/SyncView.js
@@ -306,4 +306,13 @@ Ext.define('PBS.config.SyncJobView', {
 	    sortable: true,
 	},
     ],
+
+    initComponent: function() {
+	let me = this;
+	let hideLocalDatastore = !!me.datastore;
+
+	me.columns[3].hidden = hideLocalDatastore;
+
+	me.callParent();
+    },
 });
diff --git a/www/config/VerifyView.js b/www/config/VerifyView.js
index 8a0ed6d4..26164555 100644
--- a/www/config/VerifyView.js
+++ b/www/config/VerifyView.js
@@ -234,6 +234,11 @@ Ext.define('PBS.config.VerifyJobView', {
 	    flex: 1,
 	    sortable: true,
 	},
+	{
+	    header: gettext('Datastore'),
+	    dataIndex: 'store',
+	    flex: 1,
+	},
 	{
 	    header: gettext('Skip Verified'),
 	    dataIndex: 'ignore-verified',
@@ -290,4 +295,13 @@ Ext.define('PBS.config.VerifyJobView', {
 	    sortable: true,
 	},
     ],
+
+    initComponent: function() {
+	let me = this;
+	let hideDatastore = !!me.datastore;
+
+	me.columns[1].hidden = hideDatastore;
+
+	me.callParent();
+    }
 });
-- 
2.20.1

[pbs-devel] applied: [PATCH proxmox-backup] ui: show (local)datastore column only in global sync/verifyview

[Thomas Lamprecht]

On 10.11.20 12:58, Dominik Csapak wrote:
> its rather hacky, but our cbind mixin does not support columns (yet).
> if it does sometime in the future, we could use that instead
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/config/SyncView.js   |  9 +++++++++
>  www/config/VerifyView.js | 14 ++++++++++++++
>  2 files changed, 23 insertions(+)
> 
>

applied, thanks! Follow'd up with changing this to a slightly less hard coded
way, hoping that dataIndex does not changes as often as a column reordering,
addition, or deletion may happen.

for (let column of me.columns) {
    if (column.dataIndex === 'store') {
        column.hidden = hideLocalDatastore;
        break;
    }
}