all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH widget-toolkit] Utils: fix help section normalization
@ 2020-11-10  9:34 Aaron Lauterer
  2020-11-10 10:53 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Aaron Lauterer @ 2020-11-10  9:34 UTC (permalink / raw)
  To: pve-devel

We need to replace all occurences when normalizing underscores or
dashes.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
 src/Utils.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/Utils.js b/src/Utils.js
index 7710e39..781c95d 100644
--- a/src/Utils.js
+++ b/src/Utils.js
@@ -777,11 +777,11 @@ utilities: {
 	}
 	// try to normalize - and _ separators, to support asciidoc and sphinx
 	// references at the same time.
-	let section_minus_normalized = section.replace(/_/, '-');
+	let section_minus_normalized = section.replaceAll('_', '-');
 	if (helpMap[section_minus_normalized]) {
 	    return helpMap[section_minus_normalized];
 	}
-	let section_underscore_normalized = section.replace(/-/, '_');
+	let section_underscore_normalized = section.replaceAll('-', '_');
 	return helpMap[section_underscore_normalized];
     },
 
-- 
2.20.1





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH widget-toolkit] Utils: fix help section normalization
  2020-11-10  9:34 [pve-devel] [PATCH widget-toolkit] Utils: fix help section normalization Aaron Lauterer
@ 2020-11-10 10:53 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2020-11-10 10:53 UTC (permalink / raw)
  To: Proxmox VE development discussion, Aaron Lauterer

On 10.11.20 10:34, Aaron Lauterer wrote:
> We need to replace all occurences when normalizing underscores or
> dashes.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
>  src/Utils.js | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-10 10:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-10  9:34 [pve-devel] [PATCH widget-toolkit] Utils: fix help section normalization Aaron Lauterer
2020-11-10 10:53 ` [pve-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal