* [pve-devel] [PATCH installer] don't configure vt keyboard during installation
@ 2020-11-09 15:17 ` Oguz Bektas
0 siblings, 0 replies; 4+ messages in thread
From: Oguz Bektas @ 2020-11-09 15:17 UTC (permalink / raw)
To: pve-devel, pbs-devel
in create_country_view() when setting the keyboard config
setupcon is too slow, causing installer to hang for some
seconds when switching to/from country view.
setxkbmap is enough during the installation (next step
password & email works fine with different keymaps), vt
is largely unused during it anyway.
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
proxinstall | 8 --------
1 file changed, 8 deletions(-)
diff --git a/proxinstall b/proxinstall
index dd06727..9879df4 100755
--- a/proxinstall
+++ b/proxinstall
@@ -2751,14 +2751,6 @@ sub create_country_view {
if (! $opt_testmode) {
syscmd ("setxkbmap $xkmap $xvar");
- my $kbd_config = qq{
- XKBLAYOUT="$xkmap"
- XKBVARIANT="$xvar"
- BACKSPACE="guess"
- };
- $kbd_config =~ s/^\s+//gm;
- write_config($kbd_config, '/etc/default/keyboard');
- syscmd ("setupcon");
}
}
});
--
2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pbs-devel] [PATCH installer] don't configure vt keyboard during installation
@ 2020-11-09 15:17 ` Oguz Bektas
0 siblings, 0 replies; 4+ messages in thread
From: Oguz Bektas @ 2020-11-09 15:17 UTC (permalink / raw)
To: pve-devel, pbs-devel
in create_country_view() when setting the keyboard config
setupcon is too slow, causing installer to hang for some
seconds when switching to/from country view.
setxkbmap is enough during the installation (next step
password & email works fine with different keymaps), vt
is largely unused during it anyway.
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
proxinstall | 8 --------
1 file changed, 8 deletions(-)
diff --git a/proxinstall b/proxinstall
index dd06727..9879df4 100755
--- a/proxinstall
+++ b/proxinstall
@@ -2751,14 +2751,6 @@ sub create_country_view {
if (! $opt_testmode) {
syscmd ("setxkbmap $xkmap $xvar");
- my $kbd_config = qq{
- XKBLAYOUT="$xkmap"
- XKBVARIANT="$xvar"
- BACKSPACE="guess"
- };
- $kbd_config =~ s/^\s+//gm;
- write_config($kbd_config, '/etc/default/keyboard');
- syscmd ("setupcon");
}
}
});
--
2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pve-devel] applied: [PATCH installer] don't configure vt keyboard during installation
2020-11-09 15:17 ` [pbs-devel] " Oguz Bektas
@ 2020-11-09 18:57 ` Thomas Lamprecht
-1 siblings, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2020-11-09 18:57 UTC (permalink / raw)
To: Proxmox VE development discussion, Oguz Bektas, pbs-devel
On 09.11.20 16:17, Oguz Bektas wrote:
> in create_country_view() when setting the keyboard config
> setupcon is too slow, causing installer to hang for some
> seconds when switching to/from country view.
>
> setxkbmap is enough during the installation (next step
> password & email works fine with different keymaps), vt
> is largely unused during it anyway.
>
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
> proxinstall | 8 --------
> 1 file changed, 8 deletions(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pbs-devel] applied: [pve-devel] [PATCH installer] don't configure vt keyboard during installation
@ 2020-11-09 18:57 ` Thomas Lamprecht
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2020-11-09 18:57 UTC (permalink / raw)
To: Proxmox VE development discussion, Oguz Bektas, pbs-devel
On 09.11.20 16:17, Oguz Bektas wrote:
> in create_country_view() when setting the keyboard config
> setupcon is too slow, causing installer to hang for some
> seconds when switching to/from country view.
>
> setxkbmap is enough during the installation (next step
> password & email works fine with different keymaps), vt
> is largely unused during it anyway.
>
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
> proxinstall | 8 --------
> 1 file changed, 8 deletions(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-09 18:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-09 15:17 [pve-devel] [PATCH installer] don't configure vt keyboard during installation Oguz Bektas
2020-11-09 15:17 ` [pbs-devel] " Oguz Bektas
2020-11-09 18:57 ` [pve-devel] applied: " Thomas Lamprecht
2020-11-09 18:57 ` [pbs-devel] applied: [pve-devel] " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal