all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] applied: [PATCH proxmox-backup] pxar/create: fix endless loop for shrinking files
Date: Thu, 5 Nov 2020 10:34:25 +0100	[thread overview]
Message-ID: <20201105093425.gt6qrmy4xdqmg7lk@olga.proxmox.com> (raw)
In-Reply-To: <20201105081743.7091-1-d.csapak@proxmox.com>

On Thu, Nov 05, 2020 at 09:17:43AM +0100, Dominik Csapak wrote:
> when a file shrunk during backup, we endlessly looped, reading/copying 0 bytes
> we already have code that handles shrunk files, but we forgot to
> break from the read loop
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  src/pxar/create.rs | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/pxar/create.rs b/src/pxar/create.rs
> index 6ba6f15c..f4c735d0 100644
> --- a/src/pxar/create.rs
> +++ b/src/pxar/create.rs
> @@ -661,6 +661,8 @@ impl<'a, 'b> Archiver<'a, 'b> {
>              if got as u64 > remaining {
>                  self.report_file_grew_while_reading()?;
>                  got = remaining as usize;
> +            } else if got == 0 {
> +                break; // we reached eof
>              }
>              out.write_all(&self.file_copy_buffer[..got])?;
>              remaining -= got as u64;
> -- 
> 2.20.1




      reply	other threads:[~2020-11-05  9:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-05  8:17 [pbs-devel] " Dominik Csapak
2020-11-05  9:34 ` Wolfgang Bumiller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201105093425.gt6qrmy4xdqmg7lk@olga.proxmox.com \
    --to=w.bumiller@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal