From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH-SERIES v2] some replication-related improvements
Date: Thu, 29 Oct 2020 14:31:24 +0100 [thread overview]
Message-ID: <20201029133132.28100-1-f.ebner@proxmox.com> (raw)
Is a second version for the two older series:
https://lists.proxmox.com/pipermail/pve-devel/2020-July/044550.html
https://lists.proxmox.com/pipermail/pve-devel/2020-August/044589.html
While the qemu-server patches don't require the guest-common patches,
a change to patch #7 is only relevant with the new switch_replication_target.
Changes from v1:
* Dropped an already applied patch.
* Dropped the patch: 'Hold the guest migration lock when changing the replication config'
Being able to edit a job's config while it's running is not a bad thing
as long as it doesn't cause problems. And the fact that run_replication
acquires the guest migration lock should ensure that. It guarantees that
a job cannot be removed while a migration is running (only *marked* for
removal and with patch 8 we chicken out in that case) and a new job
cannot run while a migration is running, so:
* if it's added before the migration reads the replication
config and the replication target is the migration target, the
migration itself might end up running the first replication, but
that's fine.
* otherwise it will run for the first time after migration is done.
* Dropped an RFC making job_status return jobs with source=target=local.
The replication tests would need to be adapted, and there might be
a better way than have job_status return them.
* Added patch #8 for checking if the replication job to be used for
migration is scheduled for removal.
* Split up a patch, now patch #4 + #5.
* Now that the source is updated as well, call switch_replication_job_target
for every replicated VM (even if we migrated to a non-replication target).
Previously that happened only in the was-VM-stolen-check in job_status
(still happens there for VMs that were actually stolen).
guest-common:
Fabian Ebner (5):
job_status: read only after acquiring the lock
clarify what the source property is used for in a replication job
also update sources in switch_replication_job_target
create nolock variant for switch_replication_job_target
job_status: simplify fixup of jobs for stolen guests
PVE/ReplicationConfig.pm | 46 +++++++++++++++++-----------------------
PVE/ReplicationState.pm | 42 +++++++++++++++---------------------
2 files changed, 37 insertions(+), 51 deletions(-)
qemu-server:
Fabian Ebner (3):
Repeat check for replication target in locked section
fix checks for transfering replication state/switching job target
don't migrate replicated VM whose replication job is marked for
removal
PVE/API2/Qemu.pm | 11 +++--------
PVE/QemuMigrate.pm | 30 +++++++++++++++++++++++-------
2 files changed, 26 insertions(+), 15 deletions(-)
--
2.20.1
next reply other threads:[~2020-10-29 13:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 13:31 Fabian Ebner [this message]
2020-10-29 13:31 ` [pve-devel] [PATCH v2 guest-common 1/8] job_status: read only after acquiring the lock Fabian Ebner
2020-10-29 13:31 ` [pve-devel] [PATCH v2 guest-common 2/8] clarify what the source property is used for in a replication job Fabian Ebner
2020-10-29 13:31 ` [pve-devel] [PATCH v2 guest-common 3/8] also update sources in switch_replication_job_target Fabian Ebner
2020-10-29 13:31 ` [pve-devel] [PATCH v2 guest-common 4/8] create nolock variant for switch_replication_job_target Fabian Ebner
2020-10-29 13:31 ` [pve-devel] [PATCH v2 guest-common 5/8] job_status: simplify fixup of jobs for stolen guests Fabian Ebner
2020-10-29 13:31 ` [pve-devel] [PATCH v2 qemu-server 6/8] Repeat check for replication target in locked section Fabian Ebner
2020-10-29 13:31 ` [pve-devel] [PATCH v2 qemu-server 7/8] fix checks for transfering replication state/switching job target Fabian Ebner
2020-10-29 13:31 ` [pve-devel] [PATCH/RFC v2 qemu-server 8/8] don't migrate replicated VM whose replication job is marked for removal Fabian Ebner
2020-11-09 9:48 ` [pve-devel] applied-series: [PATCH-SERIES v2] some replication-related improvements Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029133132.28100-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal