From: Dylan Whyte <d.whyte@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup] gui: Add button for changing backup group owner
Date: Tue, 27 Oct 2020 11:55:46 +0100 [thread overview]
Message-ID: <20201027105546.759-1-d.whyte@proxmox.com> (raw)
Extension of fix #2847
Adds an action button to the datastore content view,
to change the owner of a backup.
Signed-off-by: Dylan Whyte <d.whyte@proxmox.com>
---
www/BackupGroupChangeOwner.js | 88 +++++++++++++++++++++++++++++++++++
www/DataStoreContent.js | 26 ++++++++++-
www/Makefile | 1 +
3 files changed, 114 insertions(+), 1 deletion(-)
create mode 100644 www/BackupGroupChangeOwner.js
diff --git a/www/BackupGroupChangeOwner.js b/www/BackupGroupChangeOwner.js
new file mode 100644
index 00000000..5db7d115
--- /dev/null
+++ b/www/BackupGroupChangeOwner.js
@@ -0,0 +1,88 @@
+Ext.define('PBS.ChangeOwnerInputPanel', {
+ extend: 'Proxmox.panel.InputPanel',
+ alias: 'widget.pbsChangeOwnerInputPanel',
+ mixins: ['Proxmox.Mixin.CBind'],
+
+ onGetValues: function(values) {
+ var me = this;
+
+ values["backup-type"] = me.backup_type;
+ values["backup-id"] = me.backup_id;
+ return values;
+ },
+
+ controller: {
+ xclass: 'Ext.app.ViewController',
+
+ init: function(view) {
+ if (!view.url) {
+ throw "no url specified";
+ }
+ if (!view.backup_type) {
+ throw "no backup_type specified";
+ }
+ if (!view.backup_id) {
+ throw "no backup_id specified";
+ }
+
+ this.reload();
+ },
+
+ reload: function() {
+ var view = this.getView();
+
+ let params = view.getValues();
+
+ Proxmox.Utils.API2Request({
+ url: view.url,
+ method: "POST",
+ params: params,
+ });
+ },
+ },
+
+ column1: [
+ {
+ xtype: 'textfield',
+ name: 'new-owner',
+ fieldLabel: gettext('Userid'),
+ minLength: 8,
+ allowBlank: false,
+ },
+ ],
+
+});
+
+Ext.define('PBS.BackupGroupChangeOwner', {
+ extend: 'Proxmox.window.Edit',
+
+ method: 'POST',
+ submitText: "Change Owner",
+
+ initComponent: function() {
+ var me = this;
+
+ if (!me.datastore) {
+ throw "no datastore specified";
+ }
+ if (!me.backup_type) {
+ throw "no backup_type specified";
+ }
+ if (!me.backup_id) {
+ throw "no backup_id specified";
+ }
+
+ Ext.apply(me, {
+ url: '/api2/extjs/admin/datastore/' + me.datastore + "/change-owner",
+ title: "Change Owner",
+ items: [{
+ xtype: "pbsChangeOwnerInputPanel",
+ url: '/api2/extjs/admin/datastore/' + me.datastore + "/change-owner",
+ backup_type: me.backup_type,
+ backup_id: me.backup_id,
+ }],
+ });
+
+ me.callParent();
+ },
+});
diff --git a/www/DataStoreContent.js b/www/DataStoreContent.js
index 28dfd743..594b1540 100644
--- a/www/DataStoreContent.js
+++ b/www/DataStoreContent.js
@@ -267,6 +267,24 @@ Ext.define('PBS.DataStoreContent', {
}
},
+ onChangeOwner: function(view, rI, cI, item, e, rec) {
+ view = this.getView();
+
+ if (!(rec && rec.data)) return;
+ let data = rec.data;
+ if (rec.parentNode.id !== 'root') return;
+
+ if (!view.datastore) return;
+
+ let win = Ext.create('PBS.BackupGroupChangeOwner', {
+ datastore: view.datastore,
+ backup_type: data.backup_type,
+ backup_id: data.backup_id,
+ });
+ win.on('destroy', this.reload, this);
+ win.show();
+ },
+
onPrune: function(view, rI, cI, item, e, rec) {
view = this.getView();
@@ -505,7 +523,13 @@ Ext.define('PBS.DataStoreContent', {
tooltip: gettext('Verify'),
getClass: (v, m, rec) => rec.data.leaf ? 'pmx-hidden' : 'fa fa-search',
isDisabled: (v, r, c, i, rec) => !!rec.data.leaf,
- },
+ },
+ {
+ handler: 'onChangeOwner',
+ tooltip: gettext('Change Owner'),
+ getClass: (v, m, rec) => rec.parentNode.id ==='root' ? 'fa fa-user' : 'pmx-hidden',
+ isDisabled: (v, r, c, i, rec) => rec.parentNode.id !=='root',
+ },
{
handler: 'onPrune',
tooltip: gettext('Prune'),
diff --git a/www/Makefile b/www/Makefile
index e04af930..b84fdf5d 100644
--- a/www/Makefile
+++ b/www/Makefile
@@ -40,6 +40,7 @@ JSSRC= \
VersionInfo.js \
SystemConfiguration.js \
Subscription.js \
+ BackupGroupChangeOwner.js \
DataStorePrune.js \
DataStoreStatistic.js \
DataStoreContent.js \
--
2.20.1
next reply other threads:[~2020-10-27 10:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 10:55 Dylan Whyte [this message]
2020-10-27 11:41 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027105546.759-1-d.whyte@proxmox.com \
--to=d.whyte@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.