all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 2/3] partially fix #2745: use default for vzdump remove parameter
Date: Mon, 19 Oct 2020 14:33:13 +0200	[thread overview]
Message-ID: <20201019123314.8303-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20201019123314.8303-1-f.ebner@proxmox.com>

The initial default from the $confdesc is 1 anyways, and like
this, changing the default in /etc/vzdump.conf to 0 actually works.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
 PVE/VZDump.pm | 2 --
 1 file changed, 2 deletions(-)

diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index 542228d6..3ccb8269 100644
--- a/PVE/VZDump.pm
+++ b/PVE/VZDump.pm
@@ -411,8 +411,6 @@ sub new {
 
     my $defaults = read_vzdump_defaults();
 
-    $opts->{remove} = 1 if !defined($opts->{remove});
-
     foreach my $k (keys %$defaults) {
 	next if $k eq 'exclude-path' || $k eq 'maxfiles'; # dealt with separately
 	if ($k eq 'dumpdir' || $k eq 'storage') {
-- 
2.20.1





  reply	other threads:[~2020-10-19 12:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-19 12:33 [pve-devel] [PATCH guest-common 1/3] mention prune behavior for the " Fabian Ebner
2020-10-19 12:33 ` Fabian Ebner [this message]
2020-10-19 12:33 ` [pve-devel] [PATCH manager 3/3] fix #2745: backup GUI: allow users to specify remove=1 Fabian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201019123314.8303-2-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal