From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH storage 2/2] LIO: drop unused statements
Date: Mon, 12 Oct 2020 17:34:58 +0200 [thread overview]
Message-ID: <20201012153458.18685-3-s.ivanov@proxmox.com> (raw)
In-Reply-To: <20201012153458.18685-1-s.ivanov@proxmox.com>
minor cleanup of left-over/unused statements.
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
PVE/Storage/LunCmd/LIO.pm | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/PVE/Storage/LunCmd/LIO.pm b/PVE/Storage/LunCmd/LIO.pm
index f9e7143..b98edc2 100644
--- a/PVE/Storage/LunCmd/LIO.pm
+++ b/PVE/Storage/LunCmd/LIO.pm
@@ -142,8 +142,6 @@ my $parser = sub {
die "Target Portal Group has invalid value, must contain string 'tpg' and a suffix number, eg 'tpg17'\n";
}
- my $base = get_base;
-
my $config = $get_config->($scfg);
my $jsonconfig = JSON->new->utf8->decode($config);
@@ -266,7 +264,6 @@ my $list_view = sub {
# determines, if the given object exists on the portal
my $list_lun = sub {
my ($scfg, $timeout, $method, @params) = @_;
- my $name = undef;
my $object = $params[0];
my $volname = $extract_volname->($scfg, $object);
@@ -278,7 +275,7 @@ my $list_lun = sub {
}
}
- return $name;
+ return undef;
};
# adds a new LUN to the target
--
2.20.1
next prev parent reply other threads:[~2020-10-12 15:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 15:34 [pve-devel] [PATCH storage 0/2] LIO: fix tainted config and minor cleanup Stoiko Ivanov
2020-10-12 15:34 ` [pve-devel] [PATCH storage 1/2] LIO: untaint values read from remote config Stoiko Ivanov
2020-10-12 15:34 ` Stoiko Ivanov [this message]
2020-10-12 16:37 ` [pve-devel] [PATCH storage 0/2] LIO: fix tainted config and minor cleanup Daniel Berteaud
2020-10-13 9:15 ` [pve-devel] applied-series: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201012153458.18685-3-s.ivanov@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal