all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Daniel Berteaud <daniel@firewall-services.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox-acme 1/1] Close the acme standalone connection after sending a response
Date: Wed, 30 Sep 2020 16:09:09 +0200	[thread overview]
Message-ID: <20200930140909.1612753-2-daniel@firewall-services.com> (raw)
In-Reply-To: <20200930140909.1612753-1-daniel@firewall-services.com>

Without this, the first req get a response, but not the next ones as the listeners stays busy
Fixes #3048

Signed-off-by: Daniel Berteaud <daniel@firewall-services.com>
---
 src/PVE/ACME/StandAlone.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/ACME/StandAlone.pm b/src/PVE/ACME/StandAlone.pm
index 0e2ece6..552c35c 100644
--- a/src/PVE/ACME/StandAlone.pm
+++ b/src/PVE/ACME/StandAlone.pm
@@ -55,8 +55,8 @@ sub setup {
 		} else {
 		    $c->send_error(404, 'Not found.')
 		}
+		$c->close();
 	    }
-	    $c->close();
 	    $c = undef;
 	}
     }
-- 
2.26.2





  reply	other threads:[~2020-09-30 14:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30 14:09 [pve-devel] [PATCH proxmox-acme 0/1] " Daniel Berteaud
2020-09-30 14:09 ` Daniel Berteaud [this message]
2020-10-01  9:15   ` [pve-devel] [PATCH proxmox-acme 1/1] " Fabian Grünbichler
2020-10-01 10:55     ` Daniel Berteaud
2020-10-01 11:55       ` Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200930140909.1612753-2-daniel@firewall-services.com \
    --to=daniel@firewall-services.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal