From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH RFC manager 2/2] ui: grid/Replication: change the default format of schedule text
Date: Thu, 10 Sep 2020 14:57:09 +0200 [thread overview]
Message-ID: <20200910125711.28369-4-d.csapak@proxmox.com> (raw)
In-Reply-To: <20200910125711.28369-1-d.csapak@proxmox.com>
we want to sometimes elminiate the 'minute-only' syntax, so change
the defaults from '*/15' to the semantically identical '*:00/15'
make the replication edit window a bit wider to show the complete
empty text
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/grid/Replication.js | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/www/manager6/grid/Replication.js b/www/manager6/grid/Replication.js
index 19e67d90..c1f756b4 100644
--- a/www/manager6/grid/Replication.js
+++ b/www/manager6/grid/Replication.js
@@ -4,6 +4,7 @@ Ext.define('PVE.window.ReplicaEdit', {
subject: gettext('Replication Job'),
+ width: 350,
url: '/cluster/replication',
method: 'POST',
@@ -35,7 +36,7 @@ Ext.define('PVE.window.ReplicaEdit', {
{
xtype: 'pveCalendarEvent',
fieldLabel: gettext('Schedule'),
- emptyText: '*/15 - ' + Ext.String.format(gettext('Every {0} minutes'), 15),
+ emptyText: '*:00/15 - ' + Ext.String.format(gettext('Every {0} minutes'), 15),
name: 'schedule'
},
{
@@ -74,7 +75,7 @@ Ext.define('PVE.window.ReplicaEdit', {
PVE.Utils.delete_if_default(values, 'rate', '', me.isCreate);
PVE.Utils.delete_if_default(values, 'disable', 0, me.isCreate);
- PVE.Utils.delete_if_default(values, 'schedule', '*/15', me.isCreate);
+ PVE.Utils.delete_if_default(values, 'schedule', '*:00/15', me.isCreate);
PVE.Utils.delete_if_default(values, 'comment', '', me.isCreate);
if (me.isCreate) {
@@ -481,7 +482,7 @@ Ext.define('PVE.grid.ReplicaView', {
'id', 'target', 'comment', 'rate', 'type',
{ name: 'guest', type: 'integer' },
{ name: 'jobnum', type: 'integer' },
- { name: 'schedule', defaultValue: '*/15' },
+ { name: 'schedule', defaultValue: '*:00/15' },
{ name: 'disable', defaultValue: '' },
{ name: 'enabled', calculate: function(data) { return !data.disable; } }
]
--
2.20.1
next prev parent reply other threads:[~2020-09-10 12:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 12:57 [pve-devel] [PATCH RFC guest-common/manager/docs] adapt calendar events to pbs/systemd style Dominik Csapak
2020-09-10 12:57 ` [pve-devel] [PATCH RFC guest-common 1/1] ReplicationConfig: transform schedules to include always hours Dominik Csapak
2020-09-10 12:57 ` [pve-devel] [PATCH RFC manager 1/2] ui: adapt/optimize calendar event examples Dominik Csapak
2020-09-10 12:57 ` Dominik Csapak [this message]
2020-09-10 12:57 ` [pve-devel] [PATCH docs 1/2] pvesr: fix " Dominik Csapak
2020-09-10 12:57 ` [pve-devel] [PATCH RFC docs 2/2] pvesr: modify examples to fit with pbs style Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910125711.28369-4-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.