all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] ui: dc/Backup: disable pveCompressionSelector for pbs storages
@ 2020-09-03 12:08 Dominik Csapak
  2020-09-03 16:04 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2020-09-03 12:08 UTC (permalink / raw)
  To: pve-devel

like in window/Backup

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
i'd really like to incorporate that info into our storage plugin api
so that we do not have to hardcode 'pbs', but for it's okay i guess

 www/manager6/dc/Backup.js | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index e9f20596..d868dcfc 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -61,7 +61,21 @@ Ext.define('PVE.dc.BackupEdit', {
 	    nodename: 'localhost',
 	    storageContent: 'backup',
 	    allowBlank: false,
-	    name: 'storage'
+	    name: 'storage',
+	    listeners: {
+		change: function(f, v) {
+		    let store = f.getStore();
+		    let rec = store.findRecord('storage', v);
+		    let compressionSelector = me.down('pveCompressionSelector');
+
+		    if (rec && rec.data && rec.data.type === 'pbs') {
+			compressionSelector.setValue('zstd');
+			compressionSelector.setDisabled(true);
+		    } else if (!compressionSelector.getEditable()) {
+			compressionSelector.setDisabled(false);
+		    }
+		}
+	    }
 	});
 
 	var store = new Ext.data.Store({
-- 
2.20.1





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH manager] ui: dc/Backup: disable pveCompressionSelector for pbs storages
  2020-09-03 12:08 [pve-devel] [PATCH manager] ui: dc/Backup: disable pveCompressionSelector for pbs storages Dominik Csapak
@ 2020-09-03 16:04 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2020-09-03 16:04 UTC (permalink / raw)
  To: Proxmox VE development discussion, Dominik Csapak

On 03.09.20 14:08, Dominik Csapak wrote:
> like in window/Backup
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> i'd really like to incorporate that info into our storage plugin api
> so that we do not have to hardcode 'pbs', but for it's okay i guess
> 
>  www/manager6/dc/Backup.js | 16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-03 16:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-03 12:08 [pve-devel] [PATCH manager] ui: dc/Backup: disable pveCompressionSelector for pbs storages Dominik Csapak
2020-09-03 16:04 ` [pve-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal