all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 guest-common 1/5] Add move_config_to_node method
Date: Thu, 20 Aug 2020 11:11:38 +0200	[thread overview]
Message-ID: <20200820091142.23210-1-f.ebner@proxmox.com> (raw)

allows to mock it when testing and a few lines less duplication
between the migration modules.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---

Dependency bumps
{qemu-server,container} -> guest-common
are needed.

Changes from v1:
    * collect patches into one series
    * many new tests and improvements to the test modules, see last patch

 PVE/AbstractConfig.pm | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/PVE/AbstractConfig.pm b/PVE/AbstractConfig.pm
index 4c9ad2c..5d1b662 100644
--- a/PVE/AbstractConfig.pm
+++ b/PVE/AbstractConfig.pm
@@ -274,6 +274,18 @@ sub destroy_config {
     unlink $config_fn or die "failed to remove config file: $!\n";
 }
 
+# moves configuration owned by calling node to the target node.
+# dies if renaming fails.
+sub move_config_to_node {
+    my ($class, $vmid, $target_node) = @_;
+
+    my $config_fn = $class->config_file($vmid);
+    my $new_config_fn = $class->config_file($vmid, $target_node);
+
+    rename($config_fn, $new_config_fn)
+	or die "failed to move config file to node '$target_node': $!\n";
+}
+
 my $lock_file_full_wrapper = sub {
     my ($class, $vmid, $timeout, $shared, $realcode, @param) = @_;
 
-- 
2.20.1





             reply	other threads:[~2020-08-20  9:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-20  9:11 Fabian Ebner [this message]
2020-08-20  9:11 ` [pve-devel] [PATCH v2 container 2/5] Use new " Fabian Ebner
2020-08-20  9:11 ` [pve-devel] [PATCH v2 qemu-server 3/5] " Fabian Ebner
2020-08-20  9:11 ` [pve-devel] [PATCH v2 qemu-server 4/5] migration: factor out starting remote tunnel Fabian Ebner
2020-08-20  9:11 ` [pve-devel] [PATCH v2 qemu-server 5/5] create test environment for QemuMigrate.pm Fabian Ebner
2020-08-24  7:45 ` [pve-devel] applied: [PATCH v2 guest-common 1/5] Add move_config_to_node method Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200820091142.23210-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal