all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] www: fix PBS edit typos
Date: Thu, 13 Aug 2020 12:57:34 +0200	[thread overview]
Message-ID: <20200813105734.3319823-1-f.gruenbichler@proxmox.com> (raw)

and unify encryption key generation strings.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
I don't think this check for isCreate makes sense, but maybe I am
missing something?

 www/manager6/storage/PBSEdit.js | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/www/manager6/storage/PBSEdit.js b/www/manager6/storage/PBSEdit.js
index dacebfdd..a418da0c 100644
--- a/www/manager6/storage/PBSEdit.js
+++ b/www/manager6/storage/PBSEdit.js
@@ -13,16 +13,13 @@ Ext.define('Proxmox.form.PBSEncryptionCheckbox', {
 	    blabel: (get) => {
 		let v = get('value');
 		let original = get('originalValue');
-		if (get('isCreate')) {
-		    return gettext('Auto-generate a client encryption key, safed privately on cluster.');
-		}
 		if (original) {
 		    if (!v) {
-			return gettext('Warning: Existing encryption Key will be deleted!');
+			return gettext('Warning: Existing encryption key will be deleted!');
 		    }
 		    return gettext('Active');
 		} else {
-		    return gettext('Auto-generate a client encryption key, safed privately on cluster filesystem');
+		    return gettext('Auto-generate a client encryption key, saved privately on PVE cluster.');
 		}
 	    },
 	},
-- 
2.20.1





             reply	other threads:[~2020-08-13 10:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-13 10:57 Fabian Grünbichler [this message]
2020-08-19 13:45 ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200813105734.3319823-1-f.gruenbichler@proxmox.com \
    --to=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal