* [pbs-devel] [PATCH v2 backup] fix #2909: handle missing chunks gracefully in garbage collection
@ 2020-08-05 10:22 Oguz Bektas
2020-08-06 4:37 ` [pbs-devel] applied: " Dietmar Maurer
0 siblings, 1 reply; 2+ messages in thread
From: Oguz Bektas @ 2020-08-05 10:22 UTC (permalink / raw)
To: pbs-devel
instead of bailing and stopping the entire GC process, warn about the
missing chunks and continue.
this results in "TASK WARNINGS: X" as the status.
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
src/backup/datastore.rs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/backup/datastore.rs b/src/backup/datastore.rs
index ffd64b81..1565712c 100644
--- a/src/backup/datastore.rs
+++ b/src/backup/datastore.rs
@@ -436,8 +436,8 @@ impl DataStore {
tools::fail_on_shutdown()?;
let digest = index.index_digest(pos).unwrap();
if let Err(err) = self.chunk_store.touch_chunk(digest) {
- bail!("unable to access chunk {}, required by {:?} - {}",
- proxmox::tools::digest_to_hex(digest), file_name, err);
+ worker.warn(&format!("warning: unable to access chunk {}, required by {:?} - {}",
+ proxmox::tools::digest_to_hex(digest), file_name, err));
}
}
Ok(())
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pbs-devel] applied: [PATCH v2 backup] fix #2909: handle missing chunks gracefully in garbage collection
2020-08-05 10:22 [pbs-devel] [PATCH v2 backup] fix #2909: handle missing chunks gracefully in garbage collection Oguz Bektas
@ 2020-08-06 4:37 ` Dietmar Maurer
0 siblings, 0 replies; 2+ messages in thread
From: Dietmar Maurer @ 2020-08-06 4:37 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Oguz Bektas
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-06 4:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-05 10:22 [pbs-devel] [PATCH v2 backup] fix #2909: handle missing chunks gracefully in garbage collection Oguz Bektas
2020-08-06 4:37 ` [pbs-devel] applied: " Dietmar Maurer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.