all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] applied: [PATCH proxmox-backup 1/2] api2/node/termproxy: fix user in worker task
Date: Thu, 30 Jul 2020 11:58:16 +0200	[thread overview]
Message-ID: <20200730095816.s3rrmvsu4kfh6ypb@olga.proxmox.com> (raw)
In-Reply-To: <20200727065449.12717-1-d.csapak@proxmox.com>

applied this patch

On Mon, Jul 27, 2020 at 08:54:48AM +0200, Dominik Csapak wrote:
> 'username' here is without realm, but we really want to use user@realm
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  src/api2/node.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/api2/node.rs b/src/api2/node.rs
> index b80a661..e6ecc85 100644
> --- a/src/api2/node.rs
> +++ b/src/api2/node.rs
> @@ -137,7 +137,7 @@ async fn termproxy(
>      let upid = WorkerTask::spawn(
>          "termproxy",
>          None,
> -        &username,
> +        &userid,
>          false,
>          move |worker| async move {
>              // move inside the worker so that it survives and does not close the port
> -- 
> 2.20.1




      parent reply	other threads:[~2020-07-30  9:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-27  6:54 [pbs-devel] " Dominik Csapak
2020-07-27  6:54 ` [pbs-devel] [PATCH proxmox-backup 2/2] api2/node/termproxy: fix zombies on worker abort Dominik Csapak
2020-07-28 12:16   ` Wolfgang Bumiller
2020-07-28 13:08     ` Dominik Csapak
2020-07-30  9:58 ` Wolfgang Bumiller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200730095816.s3rrmvsu4kfh6ypb@olga.proxmox.com \
    --to=w.bumiller@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal