From: Stefan Reiter <s.reiter@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 1/2] ui: fix error when reloading DataStoreContent
Date: Tue, 28 Jul 2020 14:32:10 +0200 [thread overview]
Message-ID: <20200728123211.9276-1-s.reiter@proxmox.com> (raw)
...when an entry is selected, that doesn't exist after the reload.
E.g. when one deletes selects a file within a snapshot and then clicks
the delete icon for said snapshot, focusRow would then fail and the
loading mask stay on until a reload.
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
---
www/DataStoreContent.js | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/www/DataStoreContent.js b/www/DataStoreContent.js
index 5f407e98..1c08f56a 100644
--- a/www/DataStoreContent.js
+++ b/www/DataStoreContent.js
@@ -232,8 +232,10 @@ Ext.define('PBS.DataStoreContent', {
}
return selected === id;
}, undefined, true);
- view.setSelection(selection);
- view.getView().focusRow(selection);
+ if (selection) {
+ view.setSelection(selection);
+ view.getView().focusRow(selection);
+ }
}
Proxmox.Utils.setErrorMask(view, false);
--
2.20.1
next reply other threads:[~2020-07-28 12:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 12:32 Stefan Reiter [this message]
2020-07-28 12:32 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: fix in-progress snapshots always showing as "Encrypted" Stefan Reiter
2020-07-29 5:13 ` [pbs-devel] applied: " Dietmar Maurer
2020-07-29 5:13 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: fix error when reloading DataStoreContent Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728123211.9276-1-s.reiter@proxmox.com \
--to=s.reiter@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.