From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH xtermjs v2 4/4] ui: prevent accidental closing of terminal window
Date: Tue, 14 Jul 2020 13:51:06 +0200 [thread overview]
Message-ID: <20200714115106.30195-5-d.csapak@proxmox.com> (raw)
In-Reply-To: <20200714115106.30195-1-d.csapak@proxmox.com>
this prevents closing the window e.g. when pressing ctrl+w
most browsers have a function to block a website from doing that,
so users that do not want that, simply have to click that option
also, the message will (at least in chrome) not be displayed,
instead a fixed message will appear
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
new in v2, please interpret as RFC
src/www/main.js | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/src/www/main.js b/src/www/main.js
index 55834eb..43fe656 100644
--- a/src/www/main.js
+++ b/src/www/main.js
@@ -143,7 +143,7 @@ function createTerminal() {
socket.onopen = runTerminal;
socket.onclose = tryReconnect;
socket.onerror = tryReconnect;
- window.onbeforeunload = stopTerminal;
+ window.onbeforeunload = windowUnload;
updateState(states.connecting);
},
failure: function(msg) {
@@ -303,6 +303,17 @@ function clearEvents() {
term.onData(() => {});
}
+function windowUnload(e) {
+ let message = "Are you sure you want to leave this page?";
+
+ e = e || window.event;
+ if (e) {
+ e.returnValue = message;
+ }
+
+ return message;
+}
+
function stopTerminal(event) {
event = event || {};
clearEvents();
--
2.20.1
prev parent reply other threads:[~2020-07-14 11:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 11:51 [pve-devel] [PATCH xtermjs v2 0/4] rewrite in rust Dominik Csapak
2020-07-14 11:51 ` [pve-devel] [PATCH xtermjs v2 1/4] termproxy: " Dominik Csapak
2020-07-14 11:51 ` [pve-devel] [PATCH xtermjs v2 2/4] add handlebars template Dominik Csapak
2020-07-14 11:51 ` [pve-devel] [PATCH xtermjs v2 3/4] ui: improve error message handling Dominik Csapak
2020-07-14 11:51 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714115106.30195-5-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.