all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Oguz Bektas <o.bektas@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: PVE development discussion <pve-devel@pve.proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH v3 container] fix #2820: don't hotplug over existing mpX
Date: Mon, 13 Jul 2020 13:16:48 +0200	[thread overview]
Message-ID: <20200713111648.GA16309@gaia.proxmox.com> (raw)
In-Reply-To: <4a8fa320-eea0-8749-9148-dc6b7e5e1fbb@proxmox.com>

On Mon, Jul 13, 2020 at 01:00:55PM +0200, Thomas Lamprecht wrote:
> On 02.07.20 12:10, Oguz Bektas wrote:
> > check if the given mpX already exists in the config.  if it does, then
> > skip hotplugging and write the changes to [pve:pending] for the next
> > reboot of CT.
> > 
> > after rebooting the CT, the preexisting mpX will be added as unused and
> > the mpX will be mounted.
> > 
> > Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> > ---
> >  src/PVE/LXC/Config.pm | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> >
> 
> applied, thanks! Maybe we want the GUI "Add MP" to avoid pre selecting a MP id
> which is pending deletions? At least if others are still free?

yes, makes sense. i'll look into that




      reply	other threads:[~2020-07-13 11:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200702101023.237367-1-o.bektas@proxmox.com>
2020-07-13 11:00 ` Thomas Lamprecht
2020-07-13 11:16   ` Oguz Bektas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200713111648.GA16309@gaia.proxmox.com \
    --to=o.bektas@proxmox.com \
    --cc=pve-devel@pve.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal