From: "Hannes Dürr" <h.duerr@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] SPAM: [PATCH pve-network v2 0/7] add support for Nautobot IPAM
Date: Wed, 19 Feb 2025 17:36:46 +0100 [thread overview]
Message-ID: <1fb54f4a-b4d8-46f4-b90d-240d352ad76f@proxmox.com> (raw)
In-Reply-To: <mailman.127.1736338542.441.pve-devel@lists.proxmox.com>
Sorry it took me so long to reply.
* Please check that you stick to our style guidelines [0], I noted a few
things inline but please check your patches again.
* All 3 patches pve-network, pve-manager, pve-docs series can be
combined into one series
How did you test the patch, apart from the unit tests?
[0] https://pve.proxmox.com/wiki/Perl_Style_Guide
On 1/8/25 13:15, Lou Lecrivain via pve-devel wrote:
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-02-19 16:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 12:15 Lou Lecrivain via pve-devel
2025-02-19 16:36 ` Hannes Dürr [this message]
2025-03-04 16:34 ` Lou Lecrivain via pve-devel
-- strict thread matches above, loose matches on Subject: below --
2025-01-08 12:08 Lou Lecrivain via pve-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fb54f4a-b4d8-46f4-b90d-240d352ad76f@proxmox.com \
--to=h.duerr@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.