From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Lukas Wagner <l.wagner@proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 guest-common/manager 0/4] vzdump: add 'notification-mode' parameter
Date: Tue, 21 Nov 2023 13:34:53 +0100 [thread overview]
Message-ID: <1f4ca191-d109-4849-96e7-5392c068f1a9@proxmox.com> (raw)
In-Reply-To: <786a840a-6c99-4a6b-946c-c2413afee735@proxmox.com>
Am 21/11/2023 um 13:13 schrieb Lukas Wagner:
> On 11/21/23 11:55, Fiona Ebner wrote:
>> Can't we just treat 'failure' mode as always defaulting to legacy
>> sendmail? And properly deprecate the setting, showing a warning/info
>> that new notification system is not used if set to 'failure' for both
>> CLI and UI. And maybe not even allow setting it for new jobs/manual backups?
>
> I think an explicit switch here is much more obvious and predictable to
> the user.
>
> Personally I think we should wait a bit before deprecating/disallowing
> 'mailto' for new backup jobs. This gives us time to polish the UX of
> creating matchers etc. without 'forcing' the user into the new system.
>
I think so too, if it would be a new major release we might be a bit more
aggressive here, but for a point release we definitively should avoid
deprecation warnings, that something for next (or next next) major release,
possibly with an automated migration path for existing users (which would
have been a bit to much work to implement and test sanely in the remaining
time for next release)
next prev parent reply other threads:[~2023-11-21 12:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 10:22 Lukas Wagner
2023-11-21 10:22 ` [pve-devel] [PATCH v2 pve-guest-common 1/4] vzdump: config: add 'notification-mode' param for backup jobs Lukas Wagner
2023-11-21 12:32 ` [pve-devel] applied: " Thomas Lamprecht
2023-11-21 10:22 ` [pve-devel] [PATCH v2 pve-manager 2/4] vzdump: support 'notification-mode' parameter Lukas Wagner
2023-11-21 10:22 ` [pve-devel] [PATCH v2 pve-manager 3/4] ui: backup jobs: add 'notification-mode' selector for backup jobs Lukas Wagner
2023-11-21 10:22 ` [pve-devel] [PATCH v2 pve-manager 4/4] ui: backup: add 'notification-mode' param for one-shot " Lukas Wagner
2023-11-21 10:23 ` [pve-devel] [PATCH v2 guest-common/manager 0/4] vzdump: add 'notification-mode' parameter Lukas Wagner
2023-11-21 10:55 ` Fiona Ebner
2023-11-21 12:13 ` Lukas Wagner
2023-11-21 12:34 ` Fiona Ebner
2023-11-21 12:34 ` Thomas Lamprecht [this message]
2023-11-21 12:29 ` Philipp Hufnagl
2023-11-21 12:32 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f4ca191-d109-4849-96e7-5392c068f1a9@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal