Re: [pve-devel] [PATCH v2 container 1/1] pct gentoo plugin fix for systemd

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 08/05/2023 um 15:49 schrieb Jorge Ventura:
> ---
> Create variable 'inittype' in the class Gentoo to establish 'openrc' or 'systemd' procedure and implement in self_init the logic for 'inittype' based on 'systemd' in the '/sbin/init' symlink.
> For self->{inittype} = 'openrc', the previous logic is preserved; but for self->{inittype} = 'systemd', the following was implemented:    
>    1. In set_hostname function, the content removed the key 'hostname='.    
>    2. In setup_network function, the logic configure '/etc/systemd/network/<eth>.network' file as defined for systemd standard.    
> The v2 just fix the 'open' parameter to FH to remove warning.    
>     

looks OK, I'd apply this with a few small stylistic fixes as followup, but I'd
require your S-o-b here, it would be enough if you reply to this mail with (an
adapted) line like:


Signed-off-by: Full Name <email@address.example.com>


thanks!