all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Friedrich Weber <f.weber@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH access-control 1/1] fix #4609: allow valid DN in ldap/ad realm config
Date: Thu, 23 Mar 2023 15:09:08 +0100	[thread overview]
Message-ID: <1eae62a4-231a-6cd0-6cfe-43f7c6978549@proxmox.com> (raw)
In-Reply-To: <20230323131430.3185211-2-d.csapak@proxmox.com>

Tested-by: Friedrich Weber <f.weber@proxmox.com>

Tested the following:

* PVE 7.3: setup LDAP realms
  realm #1 with `base_dn ou=Foo- und Bar,dc=example,dc=com`
  realm #2 with `base_dn ou=Users,dc=example,dc=com`
  both work, i.e., sync is possible and users can log in
* Update to 7.4:
  realm #1: users cannot login ("value does not match the regex pattern")
  realm #2: still works
* With this patch:
  realm #1: login works again
  realm #2: still works

On 23/03/2023 14:14, Dominik Csapak wrote:
> we previously added support for ',' in the dns attribute by allowing a
> quoted format. the regex was sadly too restrictive:




  parent reply	other threads:[~2023-03-23 14:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-23 13:14 [pve-devel] [PATCH access-control/docs] fix #4609: fix ldap regex Dominik Csapak
2023-03-23 13:14 ` [pve-devel] [PATCH access-control 1/1] fix #4609: allow valid DN in ldap/ad realm config Dominik Csapak
2023-03-23 13:43   ` Thomas Lamprecht
2023-03-23 14:09   ` Friedrich Weber [this message]
2023-03-23 14:49   ` [pve-devel] applied: " Thomas Lamprecht
2023-03-23 13:14 ` [pve-devel] [PATCH docs 1/1] user management: ldap: specify space and number sign escaping Dominik Csapak
2023-03-23 16:15   ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1eae62a4-231a-6cd0-6cfe-43f7c6978549@proxmox.com \
    --to=f.weber@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal