From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Daniel Kral <d.kral@proxmox.com>
Subject: [pve-devel] applied: [PATCH container] api: autocomplete rootdir storages for create, move-volume and clone
Date: Tue, 10 Sep 2024 16:36:07 +0200 [thread overview]
Message-ID: <1d4e85a1-4b57-4851-ba52-61760974f5ab@proxmox.com> (raw)
In-Reply-To: <20240910112342.114849-1-d.kral@proxmox.com>
Am 10/09/2024 um 13:23 schrieb Daniel Kral:
> Adds a helper subroutine for enumerating storages that are enabled and
> have the content type `rootdir` set, therefore supporting container
> directories.
>
> The autocompletion is added to the clone command and changed for the
> create and move-volume commands, which previously suggested any storage
> device. This is misleading as these commands will fail for any storage
> that is not configured to store container directories.
>
> Signed-off-by: Daniel Kral <d.kral@proxmox.com>
> ---
> I have already noticed that the create command has the default value
> 'local' for the storage parameter, which could fail on any installation
> where the local storage is not configured to store rootdirs. This should
> be fixed in a separate patch in my opinion.
good call
> src/PVE/API2/LXC.pm | 5 +++--
> src/PVE/LXC.pm | 14 ++++++++++++++
> 2 files changed, 17 insertions(+), 2 deletions(-)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-09-10 14:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 11:23 [pve-devel] " Daniel Kral
2024-09-10 14:36 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d4e85a1-4b57-4851-ba52-61760974f5ab@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.