Re: [pve-devel] [PATCH dart_api_client 1/1] change exception toString to only print details if not null

[Dominik Csapak <d.csapak@proxmox.com>]

patch looks good to me, but do you remember where you encountered this?
would make the commit message a bit better if we know how we could trigger
this (especially when trying to test this ;) )

If you want i can fix up the commit message with an example on applying

On 5/5/25 09:28, Michael Köppl wrote:
> Without this check, the toString method returns '-> null' at the end of
> the exception message if there are no details.
> 
> Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
> ---
>   lib/src/proxmox_api_exception.dart | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/src/proxmox_api_exception.dart b/lib/src/proxmox_api_exception.dart
> index 8dddc7c..5c6f343 100644
> --- a/lib/src/proxmox_api_exception.dart
> +++ b/lib/src/proxmox_api_exception.dart
> @@ -7,6 +7,6 @@ class ProxmoxApiException implements Exception {
>   
>     @override
>     String toString() {
> -    return '$message -> $details';
> +    return details != null ? '$message -> $details' : message;
>     }
>   }



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel