Re: [pbs-devel] [PATCH proxmox-backup 3/7] ui: implment task history limit and make it configurable

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

s/implment/implement/


On 05.10.20 15:43, Dominik Csapak wrote:
> @@ -234,7 +235,10 @@ Ext.define('PBS.Dashboard', {
>  	},
>      },
>  
> -    title: gettext('Dashboard') + ' - WIP',
> +    bind: {
> +	title: gettext('Dashboard') + ' (' +
> +	    Ext.String.format(gettext('{0} days'), '{days}') + ')',
> +    },

would not do that, this suggests all dashboard data is from that days,
rather only set the title in the graphs where it actually affects things.

like, for example, ...

>  
>      layout: {
>  	type: 'column',
> @@ -248,6 +252,13 @@ Ext.define('PBS.Dashboard', {
>  	margin: '0 20 20 0',
>      },
>  
> +    tools: [
> +	{
> +	    type: 'gear',
> +	    handler: 'openDashboardOptions',
> +	},
> +    ],
> +
>      scrollable: true,
>  
>      items: [
> diff --git a/www/dashboard/LongestTasks.js b/www/dashboard/LongestTasks.js
> index f74e768e..20cf1183 100644
> --- a/www/dashboard/LongestTasks.js
> +++ b/www/dashboard/LongestTasks.js
> @@ -2,7 +2,7 @@ Ext.define('PBS.LongestTasks', {
>      extend: 'Ext.grid.Panel',
>      alias: 'widget.pbsLongestTasks',
>  
> -    title: gettext('Longest Tasks (last Month)'),
> +    title: gettext('Longest Tasks'),

... here (see above)

>  
>      hideHeaders: true,
>      rowLines: false,
> diff --git a/www/dashboard/TaskSummary.js b/www/dashboard/TaskSummary.js
> index 5e2a4b13..6f2e1d99 100644
> --- a/www/dashboard/TaskSummary.js
> +++ b/www/dashboard/TaskSummary.js
> @@ -2,7 +2,7 @@ Ext.define('PBS.TaskSummary', {
>      extend: 'Ext.panel.Panel',
>      alias: 'widget.pbsTaskSummary',
>  
> -    title: gettext('Task Summary (last Month)'),
> +    title: gettext('Task Summary'),

... and here (see above)

>  
>      controller: {
>  	xclass: 'Ext.app.ViewController',
>