Re: [pve-devel] [PATCH network/container/qemu-server v2 0/3] drop unused `firewall` argument to {add, del}_bridge_fdb()

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 05/07/2023 um 16:38 schrieb Christoph Heiss:
> While working on this code, I noticed that the `firewall` argument is
> never used (nor even declared) [0] in both
> PVE::Network::{add,del}_bridge_fdb().
> 
> Thus drop it everywhere and avoid needlessly passing around things which
> are never used anyway.
> 
> Did some quick smoke-testing and everything kept working fine, but as
> there are really no functional changes, this should not effect anything.
> 
> [ Basically just a re-spin of [1], just refreshed all patches such that
> they apply cleanly again. No actual changes between v1 and v2. ]
> 
> [0] https://git.proxmox.com/?p=pve-common.git;a=blob;f=src/PVE/Network.pm;h=a4f5ba96;hb=HEAD#l299
> [1] https://lists.proxmox.com/pipermail/pve-devel/2023-March/055970.html
> 
> pve-network:
> 
> Christoph Heiss (1):
>   sdn: zones: drop unused `firewall` argument to {add, del}_bridge_fdb()
> 
>  src/PVE/Network/SDN/Zones.pm | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> pve-container:
> 
> Christoph Heiss (1):
>   net: drop unused `firewall` argument to add_bridge_fdb()
> 
>  src/PVE/LXC.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> qemu-server:
> 
> Christoph Heiss (1):
>   net: drop unused `firewall` argument to {add, del}_bridge_fdb()
> 
>  PVE/QemuServer.pm | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> --
> 2.39.2
> 
> 

for the record, this was replaced by a series from Alexandre
https://lore.proxmox.com/pve-devel/20230926073942.3212260-1-aderumier@odiso.com/


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel