all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dylan Whyte <d.whyte@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Oguz Bektas <o.bektas@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-manager] NetworkEdit: allow setting 'mtu' option for guest network devices
Date: Mon, 7 Feb 2022 14:45:27 +0100	[thread overview]
Message-ID: <1c0137e7-2e3f-d99d-5c86-d02f283716e7@proxmox.com> (raw)
In-Reply-To: <20220207121825.722340-1-o.bektas@proxmox.com>

Hi,

Tested on Linux (Fedora 32 & Debian 11) and Windows 2019 server, and all 
seems to work.

Best regards,

Dylan


On 2/7/22 13:18, Oguz Bektas wrote:
> we already have the 'mtu' option inside the API, so we can just expose
> that option inside the 'Advanced' menu for guest network interfaces.
>
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
>   www/manager6/qemu/NetworkEdit.js | 9 +++++++++
>   1 file changed, 9 insertions(+)
>
> diff --git a/www/manager6/qemu/NetworkEdit.js b/www/manager6/qemu/NetworkEdit.js
> index b39cffdc..4ce7e7a2 100644
> --- a/www/manager6/qemu/NetworkEdit.js
> +++ b/www/manager6/qemu/NetworkEdit.js
> @@ -19,6 +19,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
>   	me.network.macaddr = values.macaddr;
>   	me.network.disconnect = values.disconnect;
>   	me.network.queues = values.queues;
> +	me.network.mtu = values.mtu;
>   
>   	if (values.rate) {
>   	    me.network.rate = values.rate;
> @@ -112,6 +113,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
>   			    'macaddr',
>   			    'rate',
>   			    'queues',
> +			    'mtu',
>   			];
>   			fields.forEach(function(fieldname) {
>   			    me.down('field[name='+fieldname+']').setDisabled(value);
> @@ -161,6 +163,13 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
>   		value: '',
>   		allowBlank: true,
>   	    },
> +	    {
> +		xtype: 'proxmoxintegerfield',
> +		name: 'mtu',
> +		fieldLabel: 'MTU',
> +		value: '',
> +		allowBlank: true,
> +	    },
>   	];
>   
>   	me.callParent();


Tested-by: Dylan Whyte <d.whyte@proxmox.com>





  reply	other threads:[~2022-02-07 13:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-07 12:18 Oguz Bektas
2022-02-07 13:45 ` Dylan Whyte [this message]
2022-02-09 18:03 ` Thomas Lamprecht
2022-02-10 10:10   ` Oguz Bektas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c0137e7-2e3f-d99d-5c86-d02f283716e7@proxmox.com \
    --to=d.whyte@proxmox.com \
    --cc=o.bektas@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal