all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox Datacenter Manager development discussion
	<pdm-devel@lists.proxmox.com>,
	Christian Ebner <c.ebner@proxmox.com>
Subject: Re: [pdm-devel] [PATCH datacenter-manager 5/7] ui: dashboard: distinguish failed remotes based on remote type
Date: Tue, 14 Oct 2025 10:47:40 +0200	[thread overview]
Message-ID: <1a9276dd-4d76-474f-be6e-3be61e0b281d@proxmox.com> (raw)
In-Reply-To: <20251013085623.211136-6-c.ebner@proxmox.com>

more of a high level comment regarding the node dashboard component, but
it fits here as well as the previous patch:

i believe we should rethink how we propagate the information
to this panel, so that we don't have to extract the correct information
inside

e.g. either we restructure the api call/data in a way to separate
the info by type in the first place, or we do that directly
after the api call.

either way I'd probably give this panel just a simple struct
with the necessary information to display

I think this would make it a bit easier to follow and less
like that we forget to e.g. check the type for the content

what do you say?

On 10/13/25 10:56 AM, Christian Ebner wrote:
> The status information api call has been extended to include type and
> error information.
> Use this information to distinguish how to show the respective node
> status message. The number of failed remotes does not take into account
> which type it is, so use the failed nodes list to filter for the
> respective remote. Further, as a PVE node can have multiple nodes while
> the PBS remote is limited to one node, so discriminate that in the
> status as well.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
>   ui/src/dashboard/mod.rs | 27 +++++++++++++++++++++------
>   1 file changed, 21 insertions(+), 6 deletions(-)
> 
> diff --git a/ui/src/dashboard/mod.rs b/ui/src/dashboard/mod.rs
> index ff63f6a..da62262 100644
> --- a/ui/src/dashboard/mod.rs
> +++ b/ui/src/dashboard/mod.rs
> @@ -27,7 +27,7 @@ use pwt::{
>   
>   use pdm_api_types::{
>       remotes::RemoteType,
> -    resource::{NodeStatusCount, ResourcesStatus},
> +    resource::{FailedRemote, NodeStatusCount, ResourcesStatus},
>       TaskStatistics,
>   };
>   use pdm_client::types::TopEntity;
> @@ -195,11 +195,26 @@ impl PdmDashboard {
>                               tr!("{0} nodes have an unknown status", unknown),
>                           )
>                       }
> -                    // FIXME, get more detailed status about the failed remotes (name, type, error)?
> -                    NodeStatusCount { online, .. } if status.failed_remotes > 0 => (
> -                        Status::Unknown.into(),
> -                        tr!("{0} of an unknown number of nodes online", online),
> -                    ),
> +                    NodeStatusCount { online, .. } if status.failed_remotes > 0 => {
> +                        let failed_remotes: Vec<&FailedRemote> = status
> +                            .failed_remotes_list
> +                            .iter()
> +                            .filter(|item| item.remote_type == remote_type)
> +                            .collect();
> +                        if failed_remotes.is_empty() {
> +                            (Status::Success.into(), tr!("{0} nodes online", online))
> +                        } else if remote_type == RemoteType::Pbs {
> +                            (
> +                                Status::Error.into(),
> +                                tr!("{0} remotes failed", failed_remotes.len()),
> +                            )
> +                        } else {
> +                            (
> +                                Status::Unknown.into(),
> +                                tr!("{0} of an unknown number of nodes online", online),
> +                            )
> +                        }
> +                    }
>                       NodeStatusCount { online, .. } => {
>                           (Status::Success.into(), tr!("{0} nodes online", online))
>                       }



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  reply	other threads:[~2025-10-14  8:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-13  8:56 [pdm-devel] [PATCH datacenter-manager 0/7] add remote type based search and PBS node status panel to dashboard Christian Ebner
2025-10-13  8:56 ` [pdm-devel] [PATCH datacenter-manager 1/7] server: api: add remote-type search category for resources Christian Ebner
2025-10-14  8:35   ` Dominik Csapak
2025-10-14  9:01     ` Christian Ebner
2025-10-13  8:56 ` [pdm-devel] [PATCH datacenter-manager 2/7] pdm-api-types: extend resource status by list of failed remotes Christian Ebner
2025-10-13  8:56 ` [pdm-devel] [PATCH datacenter-manager 3/7] server: api: collect failed remotes list while getting status Christian Ebner
2025-10-14  8:37   ` Dominik Csapak
2025-10-14 12:41     ` Christian Ebner
2025-10-14 12:53       ` Dominik Csapak
2025-10-14 13:10         ` Christian Ebner
2025-10-14 13:17           ` Dominik Csapak
2025-10-13  8:56 ` [pdm-devel] [PATCH datacenter-manager 4/7] ui: dashboard: extend node panel creation by remote type Christian Ebner
2025-10-13  8:56 ` [pdm-devel] [PATCH datacenter-manager 5/7] ui: dashboard: distinguish failed remotes based on " Christian Ebner
2025-10-14  8:47   ` Dominik Csapak [this message]
2025-10-14  9:20     ` Christian Ebner
2025-10-14  9:24       ` Dominik Csapak
2025-10-13  8:56 ` [pdm-devel] [PATCH datacenter-manager 6/7] ui: dashboard: expose PBS nodes status panel Christian Ebner
2025-10-13  8:56 ` [pdm-devel] [PATCH datacenter-manager 7/7] ui: dashboard: filter by remote type for PVE and PBS node " Christian Ebner
2025-10-17 14:13 ` [pdm-devel] superseded: [PATCH datacenter-manager 0/7] add remote type based search and PBS node status panel to dashboard Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a9276dd-4d76-474f-be6e-3be61e0b281d@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=c.ebner@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal