all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] fix #4370: ui: fix regression of preselecting tree element on login
Date: Mon, 28 Nov 2022 18:01:40 +0100	[thread overview]
Message-ID: <1a650a45-84ed-c485-e616-df107bf9ddfa@proxmox.com> (raw)
In-Reply-To: <20221128123400.2969290-1-d.csapak@proxmox.com>

Am 28/11/2022 um 13:34 schrieb Dominik Csapak:
> We want to select a tree element based on the fragment in the url after
> a login. For which we must wait for the tree (ResourceStore) to load.
> 
> Since we recently introduced the loading of '/cluster/options' to
> load the overrides of tags, etc. we fire a 'load' event with the
> intention of triggering a rerender of the tree (to include the new
> colors). If that triggers before the ResourceStore is loaded,
> we try to set the element once (which fails) and nothing is selected.
> 
> To fix this, we only trigger it if it was already loaded and is not
> currently loading. Otherwise it will be either redrawn after the ongoing
> load, or by the first load.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/manager6/Utils.js | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
>

applied, thanks!




      reply	other threads:[~2022-11-28 17:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-28 12:34 [pve-devel] " Dominik Csapak
2022-11-28 17:01 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a650a45-84ed-c485-e616-df107bf9ddfa@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal