From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Filip Schauer <f.schauer@proxmox.com>
Subject: Re: [pve-devel] [PATCH v3 qemu 3/3] Remove redundant function definition
Date: Mon, 7 Aug 2023 15:03:15 +0200 [thread overview]
Message-ID: <1a281f27-6833-3fe3-11cf-d19081fe1d7d@proxmox.com> (raw)
In-Reply-To: <20230807123853.414872-3-f.schauer@proxmox.com>
Am 07.08.23 um 14:38 schrieb Filip Schauer:
> Remove the redundant save_snapshot_error function definition and move
> the G_GNUC_PRINTF macro into function the declaration.
>
The master branch in the public repository never saw your other changes,
so you can just start fresh and squash everything into a single patch
for v4 ;) That also makes the history much easier to read in the end,
because it will only contain the clean/concise version of your changes
and not all your local history that lead up to the final version.
prev parent reply other threads:[~2023-08-07 13:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 12:38 [pve-devel] [PATCH v3 qemu 1/3] Add format attributes to function candidates Filip Schauer
2023-08-07 12:38 ` [pve-devel] [PATCH v3 qemu 2/3] Use already defined G_GNUC_PRINTF macro Filip Schauer
2023-08-07 12:38 ` [pve-devel] [PATCH v3 qemu 3/3] Remove redundant function definition Filip Schauer
2023-08-07 13:03 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a281f27-6833-3fe3-11cf-d19081fe1d7d@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=f.schauer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.