* [pve-devel] [PATCH qemu-server] print_vga_device: check if bios is defined
@ 2020-08-21 8:07 Stoiko Ivanov
2020-08-21 8:41 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Stoiko Ivanov @ 2020-08-21 8:07 UTC (permalink / raw)
To: pve-devel
Otherwise a warning is printed if the bios is not set in the config.
reported via community forum:
https://forum.proxmox.com/threads/warning-in-qemuserver.74683/
reproduced and tested that the patch fixes the issue.
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
PVE/QemuServer.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index d41f162..9112d93 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -1650,7 +1650,7 @@ sub print_vga_device {
my $edidoff = "";
if ($type eq 'VGA' && windows_version($conf->{ostype})) {
- $edidoff=",edid=off" if $conf->{bios} ne 'ovmf';
+ $edidoff=",edid=off" if (!defined($conf->{bios}) || $conf->{bios} ne 'ovmf');
}
my $q35 = PVE::QemuServer::Machine::machine_type_is_q35($conf);
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH qemu-server] print_vga_device: check if bios is defined
2020-08-21 8:07 [pve-devel] [PATCH qemu-server] print_vga_device: check if bios is defined Stoiko Ivanov
@ 2020-08-21 8:41 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2020-08-21 8:41 UTC (permalink / raw)
To: Proxmox VE development discussion, Stoiko Ivanov
On 21.08.20 10:07, Stoiko Ivanov wrote:
> Otherwise a warning is printed if the bios is not set in the config.
>
> reported via community forum:
> https://forum.proxmox.com/threads/warning-in-qemuserver.74683/
>
> reproduced and tested that the patch fixes the issue.
>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> PVE/QemuServer.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
Followed up with increasing the cfg2cmd regression test coverage for warnings,
as it catches such things then.
https://lists.proxmox.com/pipermail/pve-devel/2020-August/044734.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-21 8:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-21 8:07 [pve-devel] [PATCH qemu-server] print_vga_device: check if bios is defined Stoiko Ivanov
2020-08-21 8:41 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal