From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server] print_vga_device: check if bios is defined
Date: Fri, 21 Aug 2020 10:41:33 +0200 [thread overview]
Message-ID: <195158fd-2f27-a2b9-3bf4-d8bc8eb4ed26@proxmox.com> (raw)
In-Reply-To: <20200821080738.30247-1-s.ivanov@proxmox.com>
On 21.08.20 10:07, Stoiko Ivanov wrote:
> Otherwise a warning is printed if the bios is not set in the config.
>
> reported via community forum:
> https://forum.proxmox.com/threads/warning-in-qemuserver.74683/
>
> reproduced and tested that the patch fixes the issue.
>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> PVE/QemuServer.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
Followed up with increasing the cfg2cmd regression test coverage for warnings,
as it catches such things then.
https://lists.proxmox.com/pipermail/pve-devel/2020-August/044734.html
prev parent reply other threads:[~2020-08-21 8:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 8:07 [pve-devel] " Stoiko Ivanov
2020-08-21 8:41 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=195158fd-2f27-a2b9-3bf4-d8bc8eb4ed26@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.