Re: [pve-devel] [PATCH pve-manager] ui: node summary: use SI units for HD usage

[Christian Ebner <c.ebner@proxmox.com>]

> On 21.11.2023 11:05 CET Fiona Ebner <f.ebner@proxmox.com> wrote:
> 
>  
> Am 21.11.23 um 10:00 schrieb Christian Ebner:
> > diff --git a/www/manager6/node/StatusView.js b/www/manager6/node/StatusView.js
> > index d34724f7..a6975b6e 100644
> > --- a/www/manager6/node/StatusView.js
> > +++ b/www/manager6/node/StatusView.js
> > @@ -72,7 +72,9 @@ Ext.define('PVE.node.StatusView', {
> >  	    title: '/ ' + gettext('HD space'),
> >  	    valueField: 'rootfs',
> >  	    maxField: 'rootfs',
> > -	    renderer: Proxmox.Utils.render_node_size_usage,
> > +	    renderer: function(record) {
> > +		return Proxmox.Utils.render_size_usage(record.used, record.total, true);
> > +	    },
> 
> Would it make more sense to change render_node_size_usage directly? Then
> PMG and PBS would also get the change. Like this, it will be
> inconsistent between the products, or?

render_node_size_usage is used also for rendering memory size information, where we want IEC units.

Therefore, my initial approach was adding the `useSI` parameter to `render_node_size_usage` as second parameter, which however breaks all the other renderer invocations, I assume because the renderer invocation passes along multiple parameters.

This is why I opted for the invocation as is.

PBS already shows the HD usage values in SI units.

Cheers,
Chris