From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: [pve-devel] applied: [PATCH v3 widget-toolkit 1/2] tfa: improve UX for recovery keys and when none are left
Date: Wed, 7 Jun 2023 18:07:12 +0200 [thread overview]
Message-ID: <18cad7e6-6735-c1f8-5b4f-30645318d803@proxmox.com> (raw)
In-Reply-To: <20230606100318.110005-1-w.bumiller@proxmox.com>
Am 06/06/2023 um 12:03 schrieb Wolfgang Bumiller:
> If we get an empty challenge, tell the user to contact an
> administrator as it means no 2nd factors and no recovery
> keys are available.
>
> Currently if only 1 key was available and it had a high ID,
> we'd show something like: "Recovery keys available: 9,
> Warning, less than 4 keys available."
> Let's start off with the warning, and then be explicit about
> the IDs.
>
> Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
> ---
> changes since v2:
> - fix wrong tfa type comparison
> - hide recovery input field when no recovery keys are left
>
> src/window/TfaWindow.js | 75 ++++++++++++++++++++++++++++++++---------
> 1 file changed, 59 insertions(+), 16 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-06-07 16:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 10:03 [pve-devel] " Wolfgang Bumiller
2023-06-06 10:03 ` [pve-devel] [PATCH widget-toolkit 2/2] tfa: show 'Locked' in 'Enabled' column if tfa is locked Wolfgang Bumiller
2023-06-07 16:07 ` [pve-devel] applied: " Thomas Lamprecht
2023-06-07 16:07 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18cad7e6-6735-c1f8-5b4f-30645318d803@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.