Re: [pbs-devel] [PATCH v2 backup 4/5] clippy fixes: Box::new(_) of default value

From: Daniele Paoni <daniele@libertyline.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: Re: [pbs-devel] [PATCH v2 backup 4/5] clippy fixes: Box::new(_) of default value
Date: Fri, 16 Jun 2023 10:38:01 +0200	[thread overview]
Message-ID: <188c35ab228.28bf.7e9780bdee4b75f85db1eaaf577f3245@libertyline.com> (raw)
In-Reply-To: <20230616082731.45647-5-m.sandoval@proxmox.com>

[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]

Yk

In data 16 giugno 2023 10:27:35 Maximiliano Sandoval 
<m.sandoval@proxmox.com> ha scritto:

> From rust-lang:
>
>> Why is this bad?
>>
>> First, it’s more complex, involving two calls instead of one. Second,
>> Box::default() can be faster in certain cases.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> src/acme/plugin.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/acme/plugin.rs b/src/acme/plugin.rs
> index 478d0666..5fe8993d 100644
> --- a/src/acme/plugin.rs
> +++ b/src/acme/plugin.rs
> @@ -35,7 +35,7 @@ pub(crate) fn get_acme_plugin(
>         }
>         "standalone" => {
>             // this one has no config
> -            Box::new(StandaloneServer::default())
> +            Box::<StandaloneServer>::default()
>         }
>         other => bail!("missing implementation for plugin type '{}'", other),
>     }))
> --
> 2.39.2
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[-- Attachment #2: Type: text/html, Size: 2708 bytes --]