From: Christian Ebner <c.ebner@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #2996: client: allow optional match pattens for restore
Date: Tue, 30 Apr 2024 17:35:16 +0200 (CEST) [thread overview]
Message-ID: <1861795139.12908.1714491316539@webmail.proxmox.com> (raw)
In-Reply-To: <D0XK3VEEH0UQ.3BWU40EK3QZKH@proxmox.com>
> On 30.04.2024 17:19 CEST Gabriel Goller <g.goller@proxmox.com> wrote:
>
>
> Gave this a quick spin and it worked quite good!
>
> The only thing that didn't work was when I used '-' as a target, which
> should print everything to stdout. When using it, the --matches
> parameter is simply ignored and it dumps the whole archive on stdout.
> E.g.:
>
> proxmox-backup-client restore --matches README.rst host/debian/2024-04-30T15:08:06Z test.pxar.didx -
>
> Not sure if this is in the scope of this patch or not though.
>
> If it isn't, you can consider:
>
> Tested-by: Gabriel Goller <g.goller@proxmox.com>
Thanks a lot for testing and good catch! This should indeed not be possible and I need to add a check to disallow this combination of the `matches` being set and the `target` being stdout. Will send a new version.
Cheers,
Chris
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-04-30 15:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 13:39 Christian Ebner
2024-04-30 15:19 ` Gabriel Goller
2024-04-30 15:35 ` Christian Ebner [this message]
2024-04-30 15:59 ` Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1861795139.12908.1714491316539@webmail.proxmox.com \
--to=c.ebner@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.