From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager v2] ui: resource mappings: fix editing of mapping for non first node
Date: Fri, 26 Jul 2024 11:10:57 +0200 [thread overview]
Message-ID: <17d375bb-0597-4a19-b089-810658f24a7a@proxmox.com> (raw)
In-Reply-To: <20240726074017.503172-1-d.csapak@proxmox.com>
Am 26.07.24 um 09:40 schrieb Dominik Csapak:
> when editing the pci mapping, we set the nodename of the pci/usbselector
> to the selected node. At the same time we disable and hide the node
> selector, but it still changes it's value to the 'first' node
> (alphabetically sorted) and that triggers a change event.
>
> To prevent that we accidentally set the node of the pci/usbselector
> too, we need to check here if the field is disabled.
>
> There seems to be a race when loading the nodes for the nodeselector
> which leads to inconsistent behaviour, so this was only encountered for
> the pciselector, but theoretically it could also happen for the
> usbselector so adding that condition to both.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-07-26 9:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 7:40 [pve-devel] " Dominik Csapak
2024-07-26 9:10 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17d375bb-0597-4a19-b089-810658f24a7a@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.