From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Stefan Reiter <s.reiter@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup 1/3] backup: ensure no fixed index writers are left over either
Date: Thu, 10 Sep 2020 06:29:16 +0200 (CEST) [thread overview]
Message-ID: <1797603149.1090.1599712157268@webmail.proxmox.com> (raw)
In-Reply-To: <20200908132944.5876-1-s.reiter@proxmox.com>
applied
> On 09/08/2020 3:29 PM Stefan Reiter <s.reiter@proxmox.com> wrote:
>
>
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
> src/api2/backup/environment.rs | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/api2/backup/environment.rs b/src/api2/backup/environment.rs
> index 973563d3..f635c6f7 100644
> --- a/src/api2/backup/environment.rs
> +++ b/src/api2/backup/environment.rs
> @@ -457,11 +457,11 @@ impl BackupEnvironment {
> /// Mark backup as finished
> pub fn finish_backup(&self) -> Result<(), Error> {
> let mut state = self.state.lock().unwrap();
> - // test if all writer are correctly closed
>
> state.ensure_unfinished()?;
>
> - if state.dynamic_writers.len() != 0 {
> + // test if all writer are correctly closed
> + if state.dynamic_writers.len() != 0 || state.fixed_writers.len() != 0 {
> bail!("found open index writer - unable to finish backup");
> }
>
> --
> 2.20.1
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2020-09-10 4:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 13:29 [pbs-devel] " Stefan Reiter
2020-09-08 13:29 ` [pbs-devel] [PATCH RESEND proxmox-backup 2/3] backup: check verify state of previous backup before allowing reuse Stefan Reiter
2020-09-10 5:02 ` Dietmar Maurer
2020-09-08 13:29 ` [pbs-devel] [PATCH v3 proxmox-backup 3/3] backup: check all referenced chunks actually exist Stefan Reiter
2020-09-10 4:29 ` Dietmar Maurer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1797603149.1090.1599712157268@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=s.reiter@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.