From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Jakob Klocker <j.klocker@proxmox.com>
Subject: applied: [PATCH guest-common/manager/qemu-server v7 0/3] fix #5032: add guest time sync via QGA
Date: Wed, 18 Nov 2026 15:22:56 +0100 [thread overview]
Message-ID: <179501161066.1321919.3320586608164988877.b4-ty@b4> (raw)
In-Reply-To: <20261117123932.995999-1-j.klocker@proxmox.com>
On Tue, 17 Nov 2026 13:39:29 +0100, Jakob Klocker wrote:
> This series adds a new agent option 'sync-time-on-resume' to
> automatically synchronize the guest clock via the QEMU Guest Agent
> after operations that can leave the guest time stale. The option is
> disabled by default and only takes effect when the QEMU Guest Agent is
> enabled.
>
> When a VM resumes with a restored RAM state (waking from hibernation or
> rolling back to a snapshot that includes RAM), the guest clock
> continues from the point the state was saved and no longer matches
> wall-clock time. Skew also appears whenever the guest is briefly
> frozen and resumed - after creating a snapshot, an
> ordinary pause/resume, the resume step of a live migration, or a
> vzdump in suspend mode.
>
> [...]
Applied, thanks!
I adapted a few things while/on applying, mainly:
- ui: the agent editor now loads a value of 'yes' or 'on' for the new
option as checked. Before, it showed such a value as unchecked, so
saving any other agent setting dropped the option.
- qemu-server: reworded the FIXME about enabling the option by default
and dropped its version number, like the other major version markers.
- guest-common, qemu-server: wrapped two calls with their arguments as
one block, as proxmox-perltidy keeps that form.
On top, I added a qemu-server commit with tests for which setting
decides the sync after a rollback with RAM and for
should_sync_time_on_resume():
tests: cover the guest time sync decision, also for snapshot rollback
https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=7cf9da59d92f31c7eb00b97dcb17cfa0d7e0c2b6
Two things are still missing and could be nice as follow-ups:
- the agent section of the admin guide (qm.adoc) does not document the
new option yet.
- the Yew agent editor in proxmox-yew-comp, as used by the mobile UI and
PDM, drops the option on save, as pve-api-types does not know it yet.
That needs a regeneration of pve-api-types and a checkbox there.
[pve-guest-common] applied to pve-guest-common.git (master)
[1/1] AbstractConfig: allow passing options to snapshot_rollback
https://git.proxmox.com/?p=pve-guest-common.git;a=commitdiff;h=c40393975da1c910dccbd7f395526a7b8d10256c
[pve-manager] applied to pve-manager.git (master)
[1/1] fix #5032: ui: qemu agent: add sync-time-on-resume option
https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=a9c7e78dd99b7fbede101c7074f6c1f682737950
[qemu-server] applied to qemu-server.git (master)
[1/1] fix #5032: agent: sync guest time via QGA when the clock falls behind
https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=a78800b9dea016f853af0edde033a5201da62b1b
next prev parent reply other threads:[~2026-11-18 14:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 12:39 [PATCH guest-common/manager/qemu-server v7 0/3] fix #5032: add guest time sync via QGA Jakob Klocker
2026-11-17 12:39 ` [PATCH pve-guest-common v7 1/3] AbstractConfig: allow passing options to snapshot_rollback Jakob Klocker
2026-11-17 12:39 ` [PATCH pve-manager v7 2/3] fix #5032: ui: qemu agent: add sync-time-on-resume option Jakob Klocker
2026-11-17 12:39 ` [PATCH qemu-server v7 3/3] fix #5032: agent: sync guest time via QGA when the clock falls behind Jakob Klocker
2026-11-18 14:22 ` Thomas Lamprecht [this message]
2026-11-19 6:36 ` applied: [PATCH guest-common/manager/qemu-server v7 0/3] fix #5032: add guest time sync via QGA Jakob Klocker
2026-11-19 8:52 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179501161066.1321919.3320586608164988877.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=j.klocker@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.