From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 81BB31FF0C0 for ; Wed, 18 Nov 2026 15:25:31 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 5A3CB21676; Wed, 18 Nov 2026 15:25:29 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Jakob Klocker Subject: applied: [PATCH guest-common/manager/qemu-server v7 0/3] fix #5032: add guest time sync via QGA Date: Wed, 18 Nov 2026 15:22:56 +0100 Message-ID: <179501161066.1321919.3320586608164988877.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261117123932.995999-1-j.klocker@proxmox.com> References: <20261117123932.995999-1-j.klocker@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795011925088 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.170 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JNJZZGOKRAEW3QYYHURBHB57PAFNQ2W5 X-Message-ID-Hash: JNJZZGOKRAEW3QYYHURBHB57PAFNQ2W5 X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 17 Nov 2026 13:39:29 +0100, Jakob Klocker wrote: > This series adds a new agent option 'sync-time-on-resume' to > automatically synchronize the guest clock via the QEMU Guest Agent > after operations that can leave the guest time stale. The option is > disabled by default and only takes effect when the QEMU Guest Agent is > enabled. > > When a VM resumes with a restored RAM state (waking from hibernation or > rolling back to a snapshot that includes RAM), the guest clock > continues from the point the state was saved and no longer matches > wall-clock time. Skew also appears whenever the guest is briefly > frozen and resumed - after creating a snapshot, an > ordinary pause/resume, the resume step of a live migration, or a > vzdump in suspend mode. > > [...] Applied, thanks! I adapted a few things while/on applying, mainly: - ui: the agent editor now loads a value of 'yes' or 'on' for the new option as checked. Before, it showed such a value as unchecked, so saving any other agent setting dropped the option. - qemu-server: reworded the FIXME about enabling the option by default and dropped its version number, like the other major version markers. - guest-common, qemu-server: wrapped two calls with their arguments as one block, as proxmox-perltidy keeps that form. On top, I added a qemu-server commit with tests for which setting decides the sync after a rollback with RAM and for should_sync_time_on_resume(): tests: cover the guest time sync decision, also for snapshot rollback https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=7cf9da59d92f31c7eb00b97dcb17cfa0d7e0c2b6 Two things are still missing and could be nice as follow-ups: - the agent section of the admin guide (qm.adoc) does not document the new option yet. - the Yew agent editor in proxmox-yew-comp, as used by the mobile UI and PDM, drops the option on save, as pve-api-types does not know it yet. That needs a regeneration of pve-api-types and a checkbox there. [pve-guest-common] applied to pve-guest-common.git (master) [1/1] AbstractConfig: allow passing options to snapshot_rollback https://git.proxmox.com/?p=pve-guest-common.git;a=commitdiff;h=c40393975da1c910dccbd7f395526a7b8d10256c [pve-manager] applied to pve-manager.git (master) [1/1] fix #5032: ui: qemu agent: add sync-time-on-resume option https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=a9c7e78dd99b7fbede101c7074f6c1f682737950 [qemu-server] applied to qemu-server.git (master) [1/1] fix #5032: agent: sync guest time via QGA when the clock falls behind https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=a78800b9dea016f853af0edde033a5201da62b1b