From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Elias Huhsovitz <e.huhsovitz@proxmox.com>
Subject: partially-applied: [PATCH manager v2 0/3] ui: lxc/qemu: reduce ambiguity when attaching unused disk
Date: Tue, 10 Nov 2026 20:13:18 +0100 [thread overview]
Message-ID: <179433798761.1308914.16403700419748693459.b4-ty@b4> (raw)
In-Reply-To: <20261103092730.21635-1-e.huhsovitz@proxmox.com>
On Tue, 03 Nov 2026 10:27:27 +0100, Elias Huhsovitz wrote:
> Small UI quality of life improvements to reduce the ambiguity of
> attaching/adding an unused disk to vm/container:
> * rename 'Edit' button to 'Attach' for unused disks.
> * Convert existing buttons that display altText to
> `Proxmox.button.AltText`
> * Make button ordering of lxc/qemu hardware options consistent
>
> [...]
Partially applied, see below for reasoning, thanks!
[1/3] ui: lxc/qemu: rename button label 'Edit' to 'Attach' for unused disks
https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=8b3c66a66532d6de5753282f4474eb95202e8831
[2/3] ui: lxc/qemu: convert buttons displaying altText to proxmoxAltTextButton
https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=8167523dc71c0e9737160d6cc4c3cba29b7a8571
[3/3] ui: qemu: re-order buttons in hardware tab to match lxc layout
Skipped for now, misses at least justification for why the LXC one
is the better order – i.e., the VM one existed longer IIRC, and
here we now basically split the general edit buttons and the disk
specific edit buttons, can be maybe OK, but should be argued for
why that is OK – and we also might want to surround the remove one
by '|' to have a bit more subtle visual separation here.
prev parent reply other threads:[~2026-11-10 19:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 9:27 [PATCH manager v2 0/3] ui: lxc/qemu: reduce ambiguity when attaching unused disk Elias Huhsovitz
2026-11-03 9:27 ` [PATCH manager v2 1/3] ui: lxc/qemu: rename button label 'Edit' to 'Attach' for unused disks Elias Huhsovitz
2026-11-03 9:27 ` [PATCH manager v2 2/3] ui: lxc/qemu: convert buttons displaying altText to proxmoxAltTextButton Elias Huhsovitz
2026-11-03 9:27 ` [PATCH manager v2 3/3] ui: qemu: re-order buttons in hardware tab to match lxc layout Elias Huhsovitz
2026-11-10 19:13 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179433798761.1308914.16403700419748693459.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=e.huhsovitz@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.