From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40])
	by lore.proxmox.com (Postfix) with ESMTPS id 1310F1FF0B4
	for <inbox@lore.proxmox.com>; Tue, 10 Nov 2026 20:16:47 +0100 (CET)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 6DC8A2163F;
	Tue, 10 Nov 2026 20:16:43 +0100 (CET)
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com,
	Elias Huhsovitz <e.huhsovitz@proxmox.com>
Subject: partially-applied: [PATCH manager v2 0/3] ui: lxc/qemu: reduce
 ambiguity when attaching unused disk
Date: Tue, 10 Nov 2026 20:13:18 +0100
Message-ID: <179433798761.1308914.16403700419748693459.b4-ty@b4>
X-Mailer: git-send-email 2.47.3
In-Reply-To: <20261103092730.21635-1-e.huhsovitz@proxmox.com>
References: <20261103092730.21635-1-e.huhsovitz@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1794338198304
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.269 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: K7DIEC2JQ3ZVY2DVUAFAX5I2BPSOSBW2
X-Message-ID-Hash: K7DIEC2JQ3ZVY2DVUAFAX5I2BPSOSBW2
X-MailFrom: t.lamprecht@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On Tue, 03 Nov 2026 10:27:27 +0100, Elias Huhsovitz wrote:
> Small UI quality of life improvements to reduce the ambiguity of
> attaching/adding an unused disk to vm/container:
> * rename 'Edit' button to 'Attach' for unused disks.
> * Convert existing buttons that display altText to
>   `Proxmox.button.AltText`
> * Make button ordering of lxc/qemu hardware options consistent
> 
> [...]

Partially applied, see below for reasoning, thanks!

[1/3] ui: lxc/qemu: rename button label 'Edit' to 'Attach' for unused disks
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=8b3c66a66532d6de5753282f4474eb95202e8831
[2/3] ui: lxc/qemu: convert buttons displaying altText to proxmoxAltTextButton
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=8167523dc71c0e9737160d6cc4c3cba29b7a8571

[3/3] ui: qemu: re-order buttons in hardware tab to match lxc layout
      Skipped for now, misses at least justification for why the LXC one
      is the better order – i.e., the VM one existed longer IIRC, and
      here we now basically split the general edit buttons and the disk
      specific edit buttons, can be maybe OK, but should be argued for
      why that is OK – and we also might want to surround the remove one
      by '|' to have a bit more subtle visual separation here.