all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH container 0/2] add support for Ubuntu 26.10
@ 2026-11-06 16:59 Stoiko Ivanov
  2026-11-06 16:59 ` [PATCH container 1/2] setup: ubuntu: get version from os-release Stoiko Ivanov
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Stoiko Ivanov @ 2026-11-06 16:59 UTC (permalink / raw)
  To: pve-devel

While testing creating a container template for Ubuntu 26.10, ran
into the issue of creating failing due to /etc/lsb-release not being
present[0].

looking through the code - saw that relying on /etc/lsb-release was
added long ago (2015, with the initial Ubuntu support) - so I think
this just never was updated, as there was no need.

Tested for regression, by installing an Ubuntu 17.04 release, which is
the oldest we do not explicitly treat as unsupported. - os-release was
present there as well.

[0] verified this on a VM installed from the server-iso - also mentioned
at https://www.phoronix.com/news/Ubuntu-Drop-Debian-Version

Stoiko Ivanov (2):
  setup: ubuntu: get version from os-release
  ubuntu setup: add preliminary support for 27.04

 src/PVE/LXC/Setup/Ubuntu.pm | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

-- 
2.47.3





^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH container 1/2] setup: ubuntu: get version from os-release
  2026-11-06 16:59 [PATCH container 0/2] add support for Ubuntu 26.10 Stoiko Ivanov
@ 2026-11-06 16:59 ` Stoiko Ivanov
  2026-11-06 16:59 ` [PATCH container 2/2] ubuntu setup: add preliminary support for 27.04 Stoiko Ivanov
  2026-11-07 18:01 ` applied: [PATCH container 0/2] add support for Ubuntu 26.10 Thomas Lamprecht
  2 siblings, 0 replies; 4+ messages in thread
From: Stoiko Ivanov @ 2026-11-06 16:59 UTC (permalink / raw)
  To: pve-devel

ubuntu 26.10 does not ship /etc/lsb-release anymore, breaking setting
up a container with this version.

using /etc/lsb-release was added in 2015, and has not been touched
since:
 a8e58e9 ("add support for Ubuntu 15.04")

as /etc/os-release has the information we need in all supported
releases (checked by installing a Ubuntu 17.04 container), just use
that and drop the special treatment here.

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 src/PVE/LXC/Setup/Ubuntu.pm | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/src/PVE/LXC/Setup/Ubuntu.pm b/src/PVE/LXC/Setup/Ubuntu.pm
index e4b8c1e..374678f 100644
--- a/src/PVE/LXC/Setup/Ubuntu.pm
+++ b/src/PVE/LXC/Setup/Ubuntu.pm
@@ -45,15 +45,7 @@ my $known_versions = {
 sub new {
     my ($class, $conf, $rootdir, $os_release, $log_warn) = @_;
 
-    my $lsb_fn = "$rootdir/etc/lsb-release";
-    my $lsbinfo = PVE::Tools::file_get_contents($lsb_fn);
-
-    die "got unknown DISTRIB_ID\n" if $lsbinfo !~ m/^DISTRIB_ID=Ubuntu$/mi;
-
-    my $version;
-    if ($lsbinfo =~ m/^DISTRIB_RELEASE=(\d+\.\d+)$/mi) {
-        $version = $1;
-    }
+    my $version = $os_release->{VERSION_ID};
 
     die "unable to read version info\n" if !defined($version);
 
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH container 2/2] ubuntu setup: add preliminary support for 27.04
  2026-11-06 16:59 [PATCH container 0/2] add support for Ubuntu 26.10 Stoiko Ivanov
  2026-11-06 16:59 ` [PATCH container 1/2] setup: ubuntu: get version from os-release Stoiko Ivanov
@ 2026-11-06 16:59 ` Stoiko Ivanov
  2026-11-07 18:01 ` applied: [PATCH container 0/2] add support for Ubuntu 26.10 Thomas Lamprecht
  2 siblings, 0 replies; 4+ messages in thread
From: Stoiko Ivanov @ 2026-11-06 16:59 UTC (permalink / raw)
  To: pve-devel

follows commit:
5ae174b ("ubuntu setup: add preliminary support for 26.10")

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 src/PVE/LXC/Setup/Ubuntu.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/PVE/LXC/Setup/Ubuntu.pm b/src/PVE/LXC/Setup/Ubuntu.pm
index 374678f..84338d2 100644
--- a/src/PVE/LXC/Setup/Ubuntu.pm
+++ b/src/PVE/LXC/Setup/Ubuntu.pm
@@ -13,7 +13,8 @@ use PVE::LXC::Setup::Debian;
 use base qw(PVE::LXC::Setup::Debian);
 
 my $known_versions = {
-    '26.10' => 1, # s
+    '27.04' => 1, # t
+    '26.10' => 1, # stonking
     '26.04' => 1, # resolute LTS
     '25.10' => 1, # questing
     '25.04' => 1, # plucky
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* applied: [PATCH container 0/2] add support for Ubuntu 26.10
  2026-11-06 16:59 [PATCH container 0/2] add support for Ubuntu 26.10 Stoiko Ivanov
  2026-11-06 16:59 ` [PATCH container 1/2] setup: ubuntu: get version from os-release Stoiko Ivanov
  2026-11-06 16:59 ` [PATCH container 2/2] ubuntu setup: add preliminary support for 27.04 Stoiko Ivanov
@ 2026-11-07 18:01 ` Thomas Lamprecht
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2026-11-07 18:01 UTC (permalink / raw)
  To: pve-devel, Stoiko Ivanov

On Fri, 06 Nov 2026 17:59:34 +0100, Stoiko Ivanov wrote:
> While testing creating a container template for Ubuntu 26.10, ran
> into the issue of creating failing due to /etc/lsb-release not being
> present[0].
> 
> looking through the code - saw that relying on /etc/lsb-release was
> added long ago (2015, with the initial Ubuntu support) - so I think
> this just never was updated, as there was no need.
> 
> [...]

Applied, thanks!

[1/2] setup: ubuntu: get version from os-release
      commit: c2a51b6452a31721e50c3928e59c75b2da8551bd
[2/2] ubuntu setup: add preliminary support for 27.04
      commit: 6efd5e118727ae2c0c25baad091d20666f945bc9

Folded in two small changes: dropped the PVE::Tools import in the first
patch, as we removed its only use, and used the now known code name
tenacious' T-Rex (bit bold/jinxy name IMO, lets hope they do not follow the
animals fate) for 27.04 in the comment of the second.




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-11-07 18:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-06 16:59 [PATCH container 0/2] add support for Ubuntu 26.10 Stoiko Ivanov
2026-11-06 16:59 ` [PATCH container 1/2] setup: ubuntu: get version from os-release Stoiko Ivanov
2026-11-06 16:59 ` [PATCH container 2/2] ubuntu setup: add preliminary support for 27.04 Stoiko Ivanov
2026-11-07 18:01 ` applied: [PATCH container 0/2] add support for Ubuntu 26.10 Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal