* [PATCH pve-network] sdn: dhcp: only regenerate if no cfg is undef
@ 2026-08-31 13:06 Hannes Laimer
2026-11-02 22:51 ` applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Laimer @ 2026-08-31 13:06 UTC (permalink / raw)
To: pve-devel
Except for when there is no `.running-config` at all, these three can't
really be `undef`, and that is what this guard should check.
These three can either all be `undef`, or none. So this does not change
behaviour, but should be a little clearer.
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
src/PVE/Network/SDN/Dhcp.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Network/SDN/Dhcp.pm b/src/PVE/Network/SDN/Dhcp.pm
index 65e40d4..f6ce842 100644
--- a/src/PVE/Network/SDN/Dhcp.pm
+++ b/src/PVE/Network/SDN/Dhcp.pm
@@ -63,7 +63,7 @@ sub regenerate_config {
my $zone_cfg = $cfg->{zones};
my $vnet_cfg = $cfg->{vnets};
my $subnet_cfg = $cfg->{subnets};
- return if !$zone_cfg && !$subnet_cfg;
+ return if !$zone_cfg || !$vnet_cfg || !$subnet_cfg;
my $nodename = PVE::INotify::nodename();
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* applied: [PATCH pve-network] sdn: dhcp: only regenerate if no cfg is undef
2026-08-31 13:06 [PATCH pve-network] sdn: dhcp: only regenerate if no cfg is undef Hannes Laimer
@ 2026-11-02 22:51 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2026-11-02 22:51 UTC (permalink / raw)
To: pve-devel, Hannes Laimer
On Mon, 31 Aug 2026 15:06:47 +0200, Hannes Laimer wrote:
> Except for when there is no `.running-config` at all, these three can't
> really be `undef`, and that is what this guard should check.
>
> These three can either all be `undef`, or none. So this does not change
> behaviour, but should be a little clearer.
>
>
> [...]
Applied, thanks!
[1/1] sdn: dhcp: only regenerate if no cfg is undef
commit: 8ac5adfa0b492346fa11aa6a7c5cfb4bc8a31161
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-02 22:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-31 13:06 [PATCH pve-network] sdn: dhcp: only regenerate if no cfg is undef Hannes Laimer
2026-11-02 22:51 ` applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.